[hbase] branch branch-1.4 updated: HBASE-22701 Disable the DynamicClassLoader when it fails to initialize

[bu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

busbey pushed a commit to branch branch-1.4
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-1.4 by this push:
     new fe66dae  HBASE-22701 Disable the DynamicClassLoader when it fails to initialize
fe66dae is described below

commit fe66dae5cabf9dc1a6368f47645c646be2d0311e
Author: Josh Elser <el...@apache.org>
AuthorDate: Tue Jul 16 17:10:27 2019 -0400

    HBASE-22701 Disable the DynamicClassLoader when it fails to initialize
    
    Signed-off-by: Ankit Singhal <an...@gmail.com>
---
 .../hadoop/hbase/util/DynamicClassLoader.java      | 31 ++++++++++++++++------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java
index 07ca348..7f9e08c 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java
@@ -69,7 +69,10 @@ public class DynamicClassLoader extends ClassLoaderBase {
   private static final String DYNAMIC_JARS_OPTIONAL_CONF_KEY = "hbase.use.dynamic.jars";
   private static final boolean DYNAMIC_JARS_OPTIONAL_DEFAULT = true;
 
-  private boolean useDynamicJars;
+  // The user-provided value for using the DynamicClassLoader
+  private final boolean userConfigUseDynamicJars;
+  // The current state of whether to use the DynamicClassLoader
+  private final boolean useDynamicJars;
 
   private File localDir;
 
@@ -91,12 +94,23 @@ public class DynamicClassLoader extends ClassLoaderBase {
       final Configuration conf, final ClassLoader parent) {
     super(parent);
 
-    useDynamicJars = conf.getBoolean(
+    // Save off the user's original configuration value for the DynamicClassLoader
+    userConfigUseDynamicJars = conf.getBoolean(
         DYNAMIC_JARS_OPTIONAL_CONF_KEY, DYNAMIC_JARS_OPTIONAL_DEFAULT);
 
-    if (useDynamicJars) {
-      initTempDir(conf);
+    boolean dynamicJarsEnabled = userConfigUseDynamicJars;
+    if (dynamicJarsEnabled) {
+      try {
+        initTempDir(conf);
+        dynamicJarsEnabled = true;
+      } catch (Exception e) {
+        LOG.error("Disabling the DynamicClassLoader as it failed to initialize its temp directory."
+            + " Check your configuration and filesystem permissions. Custom coprocessor code may"
+            + " not be loaded as a result of this failure.", e);
+        dynamicJarsEnabled = false;
+      }
     }
+    useDynamicJars = dynamicJarsEnabled;
   }
 
   // FindBugs: Making synchronized to avoid IS2_INCONSISTENT_SYNC complaints about
@@ -132,12 +146,13 @@ public class DynamicClassLoader extends ClassLoaderBase {
     try {
       return parent.loadClass(name);
     } catch (ClassNotFoundException e) {
-      if (LOG.isDebugEnabled()) {
-        LOG.debug("Class " + name + " not found - using dynamical class loader");
-      }
-
       if (useDynamicJars) {
+        LOG.debug("Class " + name + " not found - using dynamical class loader");
         return tryRefreshClass(name);
+      } else if (userConfigUseDynamicJars) {
+        // If the user tried to enable the DCL, then warn again.
+        LOG.debug("Not checking DynamicClassLoader for missing class because it is disabled."
+            + " See the log for previous errors.");
       }
       throw e;
     }