[GitHub] [ozone] siddhantsangwan opened a new pull request, #5365: HDDS-9352. LegacyReplicationManager: Ignore any Datanodes that are not in-service and healthy when finding unique origins

["siddhantsangwan (via GitHub)" <gi...@apache.org>]

siddhantsangwan opened a new pull request, #5365:
URL: https://github.com/apache/ozone/pull/5365

   ## What changes were proposed in this pull request?
   
   LRM needs to save UNHEALTHY replicas that have unique Origin IDs when deleting excess UNHEALTHY replicas of a QUASI_CLOSED container. This is because replicas with unique origins are used to decide whether such a container can be closed. If we can close UNHEALTHY replicas in the future, these replicas can be used to make this decision.
   
   Currently, LRM considers all replicas in the algorithm for finding out which replicas need to be saved and which should be deleted:
   ```
       // Gather the origin node IDs of replicas which are not candidates for
       // deletion.
       Set<UUID> existingOriginNodeIDs = allReplicas.stream()
           .filter(r -> !deleteCandidates.contains(r))
           .map(ContainerReplica::getOriginDatanodeId)
           .collect(Collectors.toSet());
   ```
   We need to remove any DNs that are not in-service and healthy because it's likely we've already lost them or will lose them in the future.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-9352
   
   ## How was this patch tested?
   
   Modified an existing unit test.
   Draft only while waiting for CI to pass in my fork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] sodonnel merged pull request #5365: HDDS-9352. LegacyReplicationManager: Ignore any Datanodes that are not in-service and healthy when finding unique origins

["sodonnel (via GitHub)" <gi...@apache.org>]

sodonnel merged PR #5365:
URL: https://github.com/apache/ozone/pull/5365


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org