You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/06/28 13:37:58 UTC
Review Request 70971: Bumped mesos-tidy to 8.0.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70971/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Repository: mesos
Description
-------
Bumped mesos-tidy to 8.0.0.
Diffs
-----
support/mesos-tidy/Dockerfile c6f9d83b0c2bdf239c34f584cf521c08a6526efc
Diff: https://reviews.apache.org/r/70971/diff/1/
Testing
-------
With another patch to use a locally built image:
* `CMAKE_ARGS='-DENABLE_LIBEVENT=ON -DENABLE_SSL=ON' ./support/mesos-tidy.sh`
* `CMAKE_ARGS='-DENABLE_LIBEVENT=OFF -DENABLE_SSL=OFF' ./support/mesos-tidy.sh`
Thanks,
Benjamin Bannier
Re: Review Request 70971: Bumped mesos-tidy to 8.0.0.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70971/#review216226
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On June 28, 2019, 1:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70971/
> -----------------------------------------------------------
>
> (Updated June 28, 2019, 1:37 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Bumped mesos-tidy to 8.0.0.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile c6f9d83b0c2bdf239c34f584cf521c08a6526efc
>
>
> Diff: https://reviews.apache.org/r/70971/diff/1/
>
>
> Testing
> -------
>
> With another patch to use a locally built image:
>
> * `CMAKE_ARGS='-DENABLE_LIBEVENT=ON -DENABLE_SSL=ON' ./support/mesos-tidy.sh`
> * `CMAKE_ARGS='-DENABLE_LIBEVENT=OFF -DENABLE_SSL=OFF' ./support/mesos-tidy.sh`
>
>
> Thanks,
>
> Benjamin Bannier
>
>