[GitHub] [tvm] Lunderberg opened a new pull request #8902: [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests

[GitBox <gi...@apache.org>]

Lunderberg opened a new pull request #8902:
URL: https://github.com/apache/tvm/pull/8902


   Some unit tests in the contrib directory have not been running in CI (see https://github.com/apache/tvm/issues/8901 for tracking issue).  This PR re-enables these tests, and marks any regressions with `xfail`.
   
   [Pytest][TensorRT] Mark the TensorRT tests with tvm.testing.requires_cuda
       
   - Previously, the tests had an early bailout if tensorrt was disabled, or if there was no cuda device present.  However, the tests were not marked with `pytest.mark.gpu` and so they didn't run during `task_python_integration_gpuonly.sh`.  This commit adds the `requires_cuda` mark, and maintains the same behavior of testing the tensorrt compilation steps if compilation is enabled, and running the results if tensorrt is enabled.
       
   - In addition, some of the tests result in failures when run.  These have been marked with `pytest.mark.xfail`, and are being tracked in issue #8901.
   
   
   [UnitTests][CoreML] Marked test_annotate as a known failure.
       
   The unit tests in `test_coreml_codegen.py` haven't run in the CI lately, so this test wasn't caught before.  (See tracking issue #8901).
       
   - Added `pytest.mark.xfail` mark to `test_annotate`.
   
   - Added `tvm.testing.requires_package` decorator, which can mark tests as requiring a specific python package to be available.  Switched from `pytest.importorskip('coremltools')` to `requires_package('coremltools')` in `test_coreml_codegen.py` so that all tests would explicitly show up as skipped in the report.
   
   - Added `uses_gpu` tag to all tests in `test_coreml_codegen.py`, since only ci_gpu has coremltools installed.  In the future, if the ci_cpu image has coremltools installed, this mark can be removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron merged pull request #8902: [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests

[GitBox <gi...@apache.org>]

leandron merged pull request #8902:
URL: https://github.com/apache/tvm/pull/8902


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org