[GitHub] [solr] risdenk commented on a diff in pull request #1129: SOLR-16416: Retry overseerPrioritizer ops on failure

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1004960908


##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String overseerId) throws Excep
     overseer.sendQuitToOverseer(OverseerTaskProcessor.getLeaderId(zkStateReader.getZkClient()));
   }
 
+  private void invokeOverseerOpWithRetries(String electionNode, String op, int retryCount) {
+    boolean successful = false;
+    for (int i = 0; i < retryCount && !successful; i++) {
+      try {
+        invokeOverseerOp(electionNode, op);
+        successful = true;
+      } catch (SolrException e) {
+        if (i < retryCount - 1) {

Review Comment:
   do we want some sort of sleep/wait here?



##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -20,7 +20,9 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+

Review Comment:
   `./gradlew tidy` most likely needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org