You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/05 10:46:34 UTC

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4057: Allow deleting snapshot on local filesystem

GabrielBrascher commented on pull request #4057:
URL: https://github.com/apache/cloudstack/pull/4057#issuecomment-623982889


   1. @DaanHoogland I think that it should be on 4.13.1.0 as well indeed. Should I aim this PR for branch 4.13?
   
   2. The script is provided via the cloudstack-common package. On my test env (KVM + Ubuntu 108.04) I can confirm that the script is deployed at `/usr/share/cloudstack-common/scripts/storage/qcow2/managesnapshot.sh`.
   
   3. Additionally, the if that I edited for the `deleteSnapshot` method is similar to this else at `createSnapshot`: https://github.com/apache/cloudstack/blob/07cc49a99364a56250621d4d627a7417070e293a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1529
   
   However, on `createSnapshot` snapshot via the LVM process is executed for any case that is not an RBD. Another approach that I thought of would be to either add an if on the `createSnapshot` or remove this if that we have on the removeSnapshot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org