You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2020/08/18 17:47:52 UTC

[GitHub] [shiro] bmhm commented on pull request #250: [No JIRA] Fix inefficient iterators

bmhm commented on pull request #250:
URL: https://github.com/apache/shiro/pull/250#issuecomment-675621818


   Interesting! Sounds like yet another "best of compilation" of many code checking tools. I really like tools which can be part of a fast commit hook and/or part of the validate and verify phases.
   Ideally, code with bad habits should not be merged in the first place.
   
   In any case, I'd like to see a jira issue for this, like "enabling muse code checking" or similar.
   
   I have no strong opinion about which tool to use. As long as it fits our needs, why not? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org