You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/10 08:26:14 UTC

[GitHub] [dolphinscheduler] wendongdi commented on issue #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process

wendongdi commented on issue #11876:
URL: https://github.com/apache/dolphinscheduler/issues/11876#issuecomment-1242668258

   > Can you give an example?
   
   In current UpgradeDolphinScheduler code:
   ```JAVA
           @Override
           public void run(String... args) throws Exception {
               if (dolphinSchedulerManager.schemaIsInitialized()) {
                   dolphinSchedulerManager.upgradeDolphinScheduler();
                   logger.info("upgrade DolphinScheduler finished");
               } else {
                   dolphinSchedulerManager.initDolphinScheduler();
                   logger.info("init DolphinScheduler finished");
               }
           }
   ```
   it has been judged whether the schema has been initialized. If not, it will be initialized, but it will not upgrade after that. I don't think this is reasonable.
   The initDolphinScheduler function only update the schema to version 3.0.0(not the latest version),so i have to run this function again to upgrade the schema.
   
   I don't understand why not init&update to the latest version all at once?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org