You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/05 08:27:56 UTC
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4862: [PHP-E2E] Support v8
kezhenxu94 commented on a change in pull request #4862:
URL: https://github.com/apache/skywalking/pull/4862#discussion_r435767888
##########
File path: test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/PHPE2E.java
##########
@@ -19,7 +19,7 @@
package org.apache.skywalking.e2e;
import java.util.List;
-import java.net.URL;
+//import java.net.URL;
Review comment:
Remove this
##########
File path: test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/PHPE2E.java
##########
@@ -90,12 +90,12 @@
@BeforeAll
public void setUp() throws Exception {
- URL url = new URL("http", phpHostPort.host(), phpHostPort.port(), "/init");
- restTemplate.getForObject(url.toURI(), String.class);
- Thread.sleep(1000);
- url = new URL("http", phpShadowHostPort.host(), phpShadowHostPort.port(), "/init-shadow");
- restTemplate.getForObject(url.toURI(), String.class);
- Thread.sleep(1000);
+// URL url = new URL("http", phpHostPort.host(), phpHostPort.port(), "/init");
+// restTemplate.getForObject(url.toURI(), String.class);
+// Thread.sleep(1000);
+// url = new URL("http", phpShadowHostPort.host(), phpShadowHostPort.port(), "/init-shadow");
+// restTemplate.getForObject(url.toURI(), String.class);
+// Thread.sleep(1000);
Review comment:
Remove these please if they're useless now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org