You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/03/03 12:07:17 UTC
Review Request 57284: AMBARI-20296.Workflow Manger support for
pointing to kill node in decision editor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57284/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20296
https://issues.apache.org/jira/browse/AMBARI-20296
Repository: ambari
Description
-------
Fixed by enabling the changing of target nodes for each condition in the decision editor
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js 41bb1e5
contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js 419be37
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2f8455f
contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ce04863
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js 09bffe7
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js ae178b3
contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js d815df1
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 228f0e2
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/decision-config.hbs cb7ff46
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs d428815
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs fe46446
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs 788916b
contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js PRE-CREATION
Diff: https://reviews.apache.org/r/57284/diff/1/
Testing
-------
Manual testing
Thanks,
Padma Priya N
Re: Review Request 57284: AMBARI-20296.Workflow Manger support for
pointing to kill node in decision editor.
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57284/#review167812
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On March 3, 2017, 12:07 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57284/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 12:07 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20296
> https://issues.apache.org/jira/browse/AMBARI-20296
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by enabling the changing of target nodes for each condition in the decision editor
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js 41bb1e5
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js 419be37
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2f8455f
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ce04863
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js 09bffe7
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js ae178b3
> contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js d815df1
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 228f0e2
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/decision-config.hbs cb7ff46
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs d428815
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs fe46446
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs 788916b
> contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57284/diff/1/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 57284: AMBARI-20296.Workflow Manger support for
pointing to kill node in decision editor.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57284/#review167836
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 3, 2017, 12:07 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57284/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 12:07 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20296
> https://issues.apache.org/jira/browse/AMBARI-20296
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by enabling the changing of target nodes for each condition in the decision editor
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js 41bb1e5
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js 419be37
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2f8455f
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ce04863
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js 09bffe7
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js ae178b3
> contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js d815df1
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 228f0e2
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/decision-config.hbs cb7ff46
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs d428815
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs fe46446
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs 788916b
> contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57284/diff/1/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Padma Priya N
>
>