You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ja...@apache.org on 2020/02/25 12:29:08 UTC
[incubator-iotdb] branch FileClosedDebug updated: delete useless
logs
This is an automated email from the ASF dual-hosted git repository.
jackietien pushed a commit to branch FileClosedDebug
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git
The following commit(s) were added to refs/heads/FileClosedDebug by this push:
new 7c5f8a2 delete useless logs
7c5f8a2 is described below
commit 7c5f8a263fdc59d270523f795f7eb7d8f6560c94
Author: JackieTien97 <Ja...@foxmail.com>
AuthorDate: Tue Feb 25 20:28:52 2020 +0800
delete useless logs
---
.../apache/iotdb/db/query/control/FileReaderManager.java | 13 ++-----------
.../apache/iotdb/tsfile/read/reader/DefaultTsFileInput.java | 8 ++++++++
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java b/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java
index 1a72bbd..5a68465 100644
--- a/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java
+++ b/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java
@@ -189,18 +189,9 @@ public class FileReaderManager implements IService {
void decreaseFileReaderReference(TsFileResource tsFile, boolean isClosed) {
synchronized (this) {
if (!isClosed && unclosedReferenceMap.containsKey(tsFile)) {
- int count = closedReferenceMap.get(tsFile).decrementAndGet();
- logger.error("Unclosed file {} remain {} references", tsFile.getFile().getName(), count);
+ closedReferenceMap.get(tsFile).decrementAndGet();
} else if (closedReferenceMap.containsKey(tsFile)){
- int count = closedReferenceMap.get(tsFile).decrementAndGet();
- logger.error("Closed file {} remain {} references", tsFile.getFile().getName(), count);
- }
- Throwable ex = new Throwable();
- StackTraceElement[] stackElements = ex.getStackTrace();
- if (stackElements != null) {
- for (StackTraceElement stackElement : stackElements) {
- logger.error("Class Name: {}, Function Name: {}, Line: {}", stackElement.getClassName(), stackElement.getMethodName(), stackElement.getLineNumber());
- }
+ closedReferenceMap.get(tsFile).decrementAndGet();
}
}
tsFile.getWriteQueryLock().readLock().unlock();
diff --git a/tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/DefaultTsFileInput.java b/tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/DefaultTsFileInput.java
index 57a678e..471d89f 100644
--- a/tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/DefaultTsFileInput.java
+++ b/tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/DefaultTsFileInput.java
@@ -97,6 +97,14 @@ public class DefaultTsFileInput implements TsFileInput {
@Override
public void close() throws IOException {
+ LOGGER.error("{} FileChannel is closed", path);
+ Throwable ex = new Throwable();
+ StackTraceElement[] stackElements = ex.getStackTrace();
+ if (stackElements != null) {
+ for (StackTraceElement stackElement : stackElements) {
+ LOGGER.error("Class Name: {}, Function Name: {}, Line: {}", stackElement.getClassName(), stackElement.getMethodName(), stackElement.getLineNumber());
+ }
+ }
channel.close();
}