You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/08/28 13:24:07 UTC
[PR] fix(ui): drop the reasoning body's left rail, restore upstream geometry [maka]
Astro-Han opened a new pull request, #4089:
URL: https://github.com/apache/maka/pull/4089
## Why
The expanded 深度思考 body gained a 2px link-tinted left rail in #2645. Two problems:
1. **It is not the upstream Astryx design.** The ejected `ChatReasoning` atoms own the body's reading geometry already — secondary text color (`xv1l7n4`), 8px top padding (`x1xye8es`), 22px inline-start indent (`x1f43n9v`, `calc(16px + spacing-1-5)`) — and none of the ejected atoms draws a border. Upstream differentiates reasoning by color + indent alone.
2. **Half of the added rule was dead code.** The atoms' stacked `:not(#\#)` specificity beats the product class, so `padding-top: 2px` and `padding-inline-start: 12px` in `padding: 2px 0 4px 12px` never applied; the visible line-to-text gap was the atom's 22px, not the authored 12px.
The saturated 32%-link rail also visually outweighed the muted text it framed — the loudest element in the block was the decoration.
## What
Restore the pre-#2645 rule on `.maka-chat-reasoning-content` (`white-space: pre-wrap; word-break: break-word;` only) and let the upstream atoms own layout. Net diff vs. before #2645 is zero; the comment now records why no rail.
## Validation
- `node --test dist/__tests__/chat-turn-answer-identity.test.js` — 8/8 pass, including the test that pins `white-space: pre-wrap` on this rule.
- No test, story, or e2e fixture references the inset declarations (grep: `border-inline-start`, `margin-inline-start: 22px` only matched this rule).
AI-assisted (Maka): investigation, diff, and this description; geometry claims verified against the compiled atoms in `@astryxdesign/core` dist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): drop the reasoning body's left rail, restore upstream geometry [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4089:
URL: https://github.com/apache/maka/pull/4089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org