You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/21 11:11:10 UTC

[GitHub] [superset] xavier-GitHub76 opened a new issue, #21904: I can create two datasets based on the same table when it should be banned

xavier-GitHub76 opened a new issue, #21904:
URL: https://github.com/apache/superset/issues/21904

   Hello,
   
   when a user tries to create a dataset based on a table already in use, the following alert is displayed: "An error occurred while creating datasets: (table_name) Dataset tests already exists"
   
   ![image](https://user-images.githubusercontent.com/82046143/197181118-d75ec5b7-20bd-497f-a88d-87ec01a6f22f.png)
   
   This is normal to avoid creating duplicates... but I manage to create duplicate datasets using the import feature.
   
   The order of followings operations is important :
   
   1. Import a CSV without specify schema
   
   ![image](https://user-images.githubusercontent.com/82046143/197181913-718f15a3-c05a-4261-b896-e1ee8602b3f3.png)
   
   The dataset is created
   
   2. Create manually a dataset on the same table
   ![image](https://user-images.githubusercontent.com/82046143/197182327-d89b03b2-46ac-4a94-b498-e3dffdba4c38.png)
   
   The dataset is created again
   
   ![image](https://user-images.githubusercontent.com/82046143/197182496-e3bfd576-155e-4736-9f26-514043c8df54.png)
   
   
   In the case of a Postgres database, the default schema used is "public" if it is not specified.
   
   At the first step, the dataset created does not specify this "public" schema, 
   which makes it possible to manually create a dataset on this same table of the public schema
   
   Best regards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] I can create two datasets based on the same table when it should be banned [superset]

Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 closed issue #21904: I can create two datasets based on the same table when it should be banned
URL: https://github.com/apache/superset/issues/21904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] vonHabsi commented on issue #21904: I can create two datasets based on the same table when it should be banned

Posted by GitBox <gi...@apache.org>.
vonHabsi commented on issue #21904:
URL: https://github.com/apache/superset/issues/21904#issuecomment-1385746866

   Have you checked the creating the dataset actually created a table of the same name in the same underlying Postgres database?
   
   You are sure is it is not virtual dataset or one of the types internal to Superset?
   
   If the table was created in the underlying database then you are using a ROLE with table creation rights query the database which you shouldn't.
   
   You are supposed to create a read only ROLE in the underlying database and use that in Superset, not a role with table and/or database creation rights. Perish the thought.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] I can create two datasets based on the same table when it should be banned [superset]

Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on issue #21904:
URL: https://github.com/apache/superset/issues/21904#issuecomment-1954116886

   I reproduce the issue on 3.0.0
   cf. video


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] I can create two datasets based on the same table when it should be banned [superset]

Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on issue #21904:
URL: https://github.com/apache/superset/issues/21904#issuecomment-1954099440

   Hello,
   it's OK with version 3.0.0 👍 
   ![image](https://github.com/apache/superset/assets/82046143/f461e936-cb83-435d-8564-06375b0e9b7d)
   
   I close this issue.
   Best regards
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] I can create two datasets based on the same table when it should be banned [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #21904:
URL: https://github.com/apache/superset/issues/21904#issuecomment-1946833788

   @betodealmeida @eschutho do you see any concern here? 
   
   Also, @xavier-GitHub76 are you able to confirm that this is the case in Superset 3.x?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] xavier-GitHub76 commented on issue #21904: I can create two datasets based on the same table when it should be banned

Posted by GitBox <gi...@apache.org>.
xavier-GitHub76 commented on issue #21904:
URL: https://github.com/apache/superset/issues/21904#issuecomment-1396779946

   2 datasets (not virtual) are created :
   - one by data import
   - one by manual creation
   ![image](https://user-images.githubusercontent.com/82046143/213422810-24cec0de-1a70-42ab-a14e-50c203ad7d9b.png)
   
   Physically, in the base I have one table (created during the import)
   ![image](https://user-images.githubusercontent.com/82046143/213422677-d285e1e3-1286-41a1-9eeb-650b53ec7bf7.png)
   
   Manual creation should not be allowed because a dataset already exists.
   
   Regards
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] I can create two datasets based on the same table when it should be banned [superset]

Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on issue #21904:
URL: https://github.com/apache/superset/issues/21904#issuecomment-1954117412

   
   https://github.com/apache/superset/assets/82046143/7113ba34-dac3-4167-b735-2856acdc6412
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org