You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/10 18:55:01 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35786: [SPARK-38503][K8S] Add driver `PodGroup` templates doc and cleanup executor `PodGroup` templates

dongjoon-hyun commented on a change in pull request #35786:
URL: https://github.com/apache/spark/pull/35786#discussion_r824049076



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -59,6 +55,7 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
 
     var spec = pg.getSpec
     if (spec == null) spec = new PodGroupSpec
+    // Overwrite by driver `pod.spec.priorityClassName`

Review comment:
       Ya, that sounds fair. I also support more isolations, @Yikun .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org