You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/08 02:27:37 UTC
[GitHub] [kylin] RupengWang opened a new pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
RupengWang opened a new pull request #1310:
URL: https://github.com/apache/kylin/pull/1310
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] bigxiaochu commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452785152
##########
File path: build/conf/kylin-server-log4j.properties
##########
@@ -38,6 +38,7 @@ log4j.rootLogger=INFO
log4j.logger.org.apache.kylin=DEBUG,file
Review comment:
> When user met some exceptions, they can find more detail which maybe helpful for cause analysis .
If some logs are needed for default, they should use log.info .
DDEBUG is only needed by test or debug problem。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452626897
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
+log4j.logger.org.apache.kylin=DEBUG
+log4j.logger.org.springframework=WARN
+log4j.logger.org.springframework.security=WARN
+log4j.logger.org.apache.spark=WARN
+log4j.logger.org.apache.spark.ContextCleaner=WARN
+
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#issuecomment-658520360
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] RupengWang commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
RupengWang commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r451976570
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
+log4j.logger.org.apache.kylin=DEBUG
+log4j.logger.org.springframework=WARN
+log4j.logger.org.springframework.security=WARN
+log4j.logger.org.apache.spark=WARN
+log4j.logger.org.apache.spark.ContextCleaner=WARN
+
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
Review comment:
This log4j configuration file is used for Spark job. If the job is submitted to yarn. The normal file appender cannot be used.
We need to extend a new appender by ourselves to let the log of spark job(both driver and executor) write into HDFS which can be realized in the future.
Kylin submit a spark job by a command executor client. It will gather the output of spark job and save into kylin.log .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] bigxiaochu commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452306387
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,stdout
+log4j.logger.org.apache.kylin=DEBUG
Review comment:
should default is info?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452626808
##########
File path: build/conf/kylin-server-log4j.properties
##########
@@ -38,6 +38,7 @@ log4j.rootLogger=INFO
log4j.logger.org.apache.kylin=DEBUG,file
Review comment:
When user met some exceptions, they can find more detail which maybe helpful for cause analysis .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] RupengWang commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
RupengWang commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r451976460
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
Review comment:
Sorry, it means nothing, I will delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r451410546
##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2712,6 +2714,22 @@ public boolean isSparkEngineEnabled() {
return Boolean.parseBoolean(getOptional("kylin.query.spark-engine.enabled", "true"));
}
+ public String getLogSparkPropertiesFile() {
+ return getLogPropertyFile("kylin-parquet-log4j.properties");
+ }
+
+ private String getLogPropertyFile(String filename) {
+ String parentFolder;
+ if (isDevEnv()) {
+ parentFolder = Paths.get(getKylinHomeWithoutWarn(), "build", "conf").toString();
+ } else if (Files.exists(Paths.get(getKylinHomeWithoutWarn(), "conf", filename))) {
+ parentFolder = Paths.get(getKylinHomeWithoutWarn(), "conf").toString();
+ } else {
+ parentFolder = Paths.get(getKylinHomeWithoutWarn(), "server", "conf").toString();
Review comment:
In which case did `$KYLIN_HOME/server/conf` exists?
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
+log4j.logger.org.apache.kylin=DEBUG
+log4j.logger.org.springframework=WARN
+log4j.logger.org.springframework.security=WARN
+log4j.logger.org.apache.spark=WARN
+log4j.logger.org.apache.spark.ContextCleaner=WARN
+
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
Review comment:
I am not really sure, but I want to ask why not write log into a file?
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
Review comment:
What is `hdfs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] RupengWang closed pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
RupengWang closed pull request #1310:
URL: https://github.com/apache/kylin/pull/1310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1310:
URL: https://github.com/apache/kylin/pull/1310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] bigxiaochu commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452308651
##########
File path: build/conf/kylin-server-log4j.properties
##########
@@ -38,6 +38,7 @@ log4j.rootLogger=INFO
log4j.logger.org.apache.kylin=DEBUG,file
Review comment:
why not INFO for default？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] bigxiaochu commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452310790
##########
File path: core-common/src/main/resources/kylin-defaults.properties
##########
@@ -345,6 +346,7 @@ kylin.engine.spark-conf-mergedict.spark.memory.fraction=0.2
kylin.query.spark-conf.spark.executor.cores=5
kylin.query.spark-conf.spark.executor.instances=4
+
Review comment:
remove diff？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] bigxiaochu commented on a change in pull request #1310: KYLIN-4621 Avoid annoying log message when build cube and query
Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r452309055
##########
File path: build/conf/kylin-tools-log4j.properties
##########
@@ -35,4 +35,7 @@ log4j.appender.stderr.layout.ConversionPattern=%d{ISO8601} %-5p [%t] %c{2}:%L :
#log4j.logger.org.apache.hadoop=ERROR
log4j.logger.org.apache.kylin=DEBUG
Review comment:
same， why not info？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org