[GitHub] [incubator-shardingsphere-example] taojintianxia opened a new pull request #107: Docker enhancement proxy environment

[GitBox <gi...@apache.org>]

taojintianxia opened a new pull request #107: Docker enhancement proxy environment
URL: https://github.com/apache/incubator-shardingsphere-example/pull/107
 
 
   Fixes Nothing,  just an enhancement
   
   Changes proposed in this pull request:
   - add docker compose for proxy sharding situation
   - change the position of docker compose file for sharding jdbc 
   
   #### access docker/sharding-proxy/sharding , and then launch command by "docker compose up -d", docker will establish proxy , mysql container, then access proxy by "mysql -uroot -h127.0.0.1 -P13308 -proot"
   
   #### however, there are something we need pay attention as followings :
    - 1. access proxy by 127.0.0.1 not localhost , remember . localhost and 127.0.0.1 are different, I may fix this difference in next PR
    - 2. entrypoint for proxy image is launch start.sh and print out log immediately, if we just launch proxy container, that's fine. however , by compose , we have to let it wait until related mysql container finished it's initialization . so I invoke the "wait-for-it.sh" . default await completion is 20 seconds , which means proxy container will not launch if mysql container CAN NOT FINISH INITIALIZATION in 20 sec. of course , you can change it (-timeout=20).
    - 3. the correct way to shutdown docker-compose is "docker-compose down", stop and delete every single container is a little bit stupid . please modify the corresponding document in README.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services