[kudu-CR] env posix: add more failure cases to Walk

["Adar Dembo (Code Review)" <ge...@cloudera.org>]

Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8171

to look at the new patch set (#2).

Change subject: env_posix: add more failure cases to Walk
......................................................................

env_posix: add more failure cases to Walk

The manpage for fts_read has this to say about FTS_DNR and FTS_NS:

  FTS_DNR     A directory which cannot be read. This is an error return, and
              the fts_errno field will be set to indicate what caused the
              error.

  FTS_NS      A file for which no stat(2) information was available. The
              contents of the fts_statp field are undefined. This is an
              error return, and the fts_errno field will be set to indicate
              what caused the error.

As such, we should treat them the same as FTS_ERR.

The new tests fail without this change, which I found somewhat surprising;
I would have expected fts_open(2) to check for the existence and readability
of the root directory, but apparently that's deferred to fts_read(2).

Change-Id: I16edaec169d074913768c95a16173ff105d7b6a1
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 63 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8171/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16edaec169d074913768c95a16173ff105d7b6a1
Gerrit-Change-Number: 8171
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>