[jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857453#comment-16857453 ] 

ASF GitHub Bot commented on AIRFLOW-4316:
-----------------------------------------

mppetkov commented on pull request #5379: AIRFLOW-4316 Don't make automatically lower case every variable from …
URL: https://github.com/apache/airflow/pull/5379
 
 
   …the config
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4316
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
> ---------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4316
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4316
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: configuration, contrib
>    Affects Versions: 1.10.3
>            Reporter: Vlad Precup
>            Priority: Major
>              Labels: configuration, kubernetes
>             Fix For: 1.10.4
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> All the environment variable names declared under the kubernetes_environment_variables section are converted to lowercase in the newly generated pods when running Airflow with the KubernetesExecutor in version 1.10.3.
> The behavior is not aligned with the comments in the documentation / code comments in the default config file, airflow.cfg.
> Investigation helper:
> Since we are treating all the sections uniformly in the configuration component, all the keys are lowered (i.e. `configuration.py`, line 342 ->`key = env_var.replace(section_prefix, '').lower()`)
> Please also write (a) unit test(s) for this special case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)