[GitHub] [datasketches-memory] leerho commented on a change in pull request #138: This test mimics the Druid issue #11544, but at a much smaller scale.

[GitBox <gi...@apache.org>]

leerho commented on a change in pull request #138:
URL: https://github.com/apache/datasketches-memory/pull/138#discussion_r686352320



##########
File path: datasketches-memory-java8-tests/src/test/java/org/apache/datasketches/memory/test/Buffer2Test.java
##########
@@ -406,6 +408,14 @@ public void testIllegalFill() {
     wbuf.fill((byte)0);
   }
 
+  @Test
+  public void checkWritableWrap() {
+    ByteBuffer bb = ByteBuffer.allocate(16);
+    WritableBuffer buf = WritableBuffer.writableWrap(bb, ByteOrder.nativeOrder(), null);
+    buf = WritableBuffer.writableWrap(bb, ByteOrder.nativeOrder(), new DefaultMemoryRequestServer());
+    assertNotNull(buf);

Review comment:
       Yes, I should have checked twice, but it is very unlikely that one would be null and the other not. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org