You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/21 12:26:31 UTC
[GitHub] [airflow] kaxil opened a new pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
kaxil opened a new pull request #17133:
URL: https://github.com/apache/airflow/pull/17133
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884159915
Is there a way to disable these and maybe set it in breeze? It’d be a bit annoying to see it show up when I’m absolutely just testing things…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884290106
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884294726
One small thing though. I just double-checked that `UNIT_TEST_MODE` is not set in Breeze by default. So when you run `start-airflow` the message will show up.
The UNIT_TEST_MODE is only set when we run tests (it's done using pytest automated fixture). It used to be set long time ago but it's been removed when we switched to pytest.
The best way to check if you are in Breeze is to check BREEZE environment variable (set to "true").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884457935
> YAY. Love that you link to helpful documentation.
oh yeah. I noticed that and extra +1 from me on that one as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884178339
Sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884175587
> Is there a way to disable these and maybe set it in breeze? It’d be a bit annoying to see it show up when I’m absolutely just testing things…
I can make it so that you don't see these error if unit_test mode is on: https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#unit-test-mode (`AIRFLOW__CORE__UNIT_TEST_MODE=True`) -- Will that suffice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17133:
URL: https://github.com/apache/airflow/pull/17133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leahecole commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
leahecole commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884413019
YAY. Love that you link to helpful documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884290736
Love it! and the Unit-test exclusion as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17133: Warn on Webserver when using ``SQLite`` or ``SequentialExecutor``
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17133:
URL: https://github.com/apache/airflow/pull/17133#issuecomment-884295996
Maybe we could also check if airflow is installed in "editable" mode. Seems it is possible https://stackoverflow.com/questions/40530000/check-if-my-application-runs-in-development-editable-mode (@uranusjr - how reliable it might be :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org