You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2005/04/11 18:27:18 UTC
DO NOT REPLY [Bug 34076] -
overriding content.xml docBase with manager webapp deploy function fails with java.util.zip.ZipException if context.xml specifies war and manager specifies directory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34076>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34076
------- Additional Comments From daniel.santos@pobox.com 2005-04-11 18:27 -------
More info on this bug:
The context.xml that you supply to the Manager is unaltered, it appears to be
copied verbatim to $CATALINA_HOME/conf/<serviceName>/<hostName>/ (where
context.xml files go). The next time that Tomcat starts, it reads these values
and will thus deploy (or attempt to deploy) differently than when it was
deployed with the Manager specifying the overriding parameters.
I think that the solution is to re-write the context.xml file rather than adding
code to handle the special case of the overridden war file. After it is
re-written, it can then be parsed and processed as though there were no
exceptions. This would solve several problems at once. If I understand the
commons component correctly that creates these objects (which I only barely
understand it) from the xml then we would only be running that after we re-wrote
the xml.
That would solve both problems, the ".war file vs. war layout directory" issue
and the "next time you boot Tomcat it uses old war value" issue. Then the file
could be written to conf/<service name>/<host name> correctly and it's much
smoother.
Now, how should we re-write it? We can parse it, change the values and then
write it out or we can basically find and replace hack it. But I'm personally
for a more sophisticated solution that is probably a bigger mouthful then
anybody wants, but it's an idea....
I have long since been unsatisfied with the Admin webapps behavior of writing
out my xml files with comments stripped and it's own (not too friendly)
formatting. It would be really nice if there was a somewhat extended parsing
functionality that records comments as metadata. If we wanted to go a bit
further, we could also attempt to analyze the formatting to determine what
formatting conventions is being used along with a probability factor of how
certain they are using that convention (some people just sorta throw up in their
code editor and call it art). Then, when we write it, we can write the comments
back out and reusing their original formatting convention if it was consistent
enough, or use a better formatting convention than we are currently at least.
Daniel
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org