You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/18 16:41:07 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2058: HDDS-4993. Add guardrail for reserved buffer size when DN reads a chunk
adoroszlai opened a new pull request #2058:
URL: https://github.com/apache/ozone/pull/2058
## What changes were proposed in this pull request?
Currently DN reserves a byte buffer for client's chunk read request based on whatever client specifies, without check. Client can send a message forcing DN to allocate up to 2GB memory per request.
This change makes DN reject read requests if chunk length specified by client is over the maximum allowed chunk size (32MB). Normally this should not happen, as chunk info is fetched before read from the server.
https://issues.apache.org/jira/browse/HDDS-4993
## How was this patch tested?
Added unit test.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/664486050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2058: HDDS-4993. Add guardrail for reserved buffer size when DN reads a chunk
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2058:
URL: https://github.com/apache/ozone/pull/2058#issuecomment-851200416
Thanks @elek for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2058: HDDS-4993. Add guardrail for reserved buffer size when DN reads a chunk
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2058:
URL: https://github.com/apache/ozone/pull/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org