[GitHub] [incubator-iceberg] arina-ielchiieva edited a comment on issue #330: Orphan manifest file when performing delete in transaction

[GitBox <gi...@apache.org>]

arina-ielchiieva edited a comment on issue #330: Orphan manifest file when performing delete in transaction
URL: https://github.com/apache/incubator-iceberg/issues/330#issuecomment-516909923
 
 
   @rdblue thanks for the details. Looks like you have identify root cause correctly.
   When I have commented out `filteredManifests.remove(manifest);` line:
   ```
     private void cleanUncommittedFilters(Set<ManifestFile> committed) {
       // iterate over a copy of entries to avoid concurrent modification
       List<Map.Entry<ManifestFile, ManifestFile>> filterEntries =
           Lists.newArrayList(filteredManifests.entrySet());
   
       for (Map.Entry<ManifestFile, ManifestFile> entry : filterEntries) {
         // remove any new filtered manifests that aren't in the committed list
         ManifestFile manifest = entry.getKey();
         ManifestFile filtered = entry.getValue();
         if (!committed.contains(filtered)) {
           // only delete if the filtered copy was created
           if (!manifest.equals(filtered)) {
             deleteFile(filtered.path());
           }
   
           // remove the entry from the cache
           //filteredManifests.remove(manifest);
         }
       }
     }
   ```
   Delete operation in transaction produced only one manifest file.
   Is this what need to be fixed (to tell the truth I did not completely explore the code,  just tried out the suggested fix)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org