You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2012/02/21 14:00:03 UTC
Re: svn commit: r1291632 - /jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
On 21 February 2012 07:41, <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Tue Feb 21 07:41:05 2012
> New Revision: 1291632
>
> URL: http://svn.apache.org/viewvc?rev=1291632&view=rev
> Log:
> Bug 52672 - Change Controller action deletes all but one child samplers
> Added doc
>
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java?rev=1291632&r1=1291631&r2=1291632&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java Tue Feb 21 07:41:05 2012
> @@ -79,6 +79,7 @@ public class ChangeParent implements Com
> treeModel.removeNodeFromParent(currentNode);
> int childCount = currentNode.getChildCount();
> for (int i = 0; i < childCount; i++) {
> + // Using index 0 is voluntary as child is removed in next step and added to new parent
s/voluntary/required/ ?
> JMeterTreeNode node = (JMeterTreeNode) currentNode.getChildAt(0);
> treeModel.removeNodeFromParent(node);
> treeModel.insertNodeInto(node, newNode, newNode.getChildCount());
>
>
Re: svn commit: r1291632 - /jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello Sebb,
required if it's your question.
Regards
Philippe
On Tue, Feb 21, 2012 at 2:00 PM, sebb <se...@gmail.com> wrote:
> On 21 February 2012 07:41, <pm...@apache.org> wrote:
> > Author: pmouawad
> > Date: Tue Feb 21 07:41:05 2012
> > New Revision: 1291632
> >
> > URL: http://svn.apache.org/viewvc?rev=1291632&view=rev
> > Log:
> > Bug 52672 - Change Controller action deletes all but one child samplers
> > Added doc
> >
> > Modified:
> > jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
> >
> > Modified:
> jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java?rev=1291632&r1=1291631&r2=1291632&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
> (original)
> > +++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/ChangeParent.java
> Tue Feb 21 07:41:05 2012
> > @@ -79,6 +79,7 @@ public class ChangeParent implements Com
> > treeModel.removeNodeFromParent(currentNode);
> > int childCount = currentNode.getChildCount();
> > for (int i = 0; i < childCount; i++) {
> > + // Using index 0 is voluntary as child is removed in next
> step and added to new parent
>
> s/voluntary/required/ ?
>
> > JMeterTreeNode node = (JMeterTreeNode)
> currentNode.getChildAt(0);
> > treeModel.removeNodeFromParent(node);
> > treeModel.insertNodeInto(node, newNode,
> newNode.getChildCount());
> >
> >
>
--
Cordialement.
Philippe Mouawad.