[GitHub] [arrow-datafusion] korowa commented on a diff in pull request #2647: pushdown support for predicates in `ON` clause of joins

[GitBox <gi...@apache.org>]

korowa commented on code in PR #2647:
URL: https://github.com/apache/arrow-datafusion/pull/2647#discussion_r887557450


##########
datafusion/core/src/optimizer/filter_push_down.rs:
##########
@@ -1351,7 +1427,7 @@ mod tests {
         let right = LogicalPlanBuilder::from(right_table_scan)
             .project(vec![col("a"), col("b"), col("c")])?
             .build()?;
-        let filter = col("test.a")
+        let filter = col("test.c")

Review Comment:
   Exactly, I've decided not to mix these cases and moved case with filtering on one of join keys to `join_filter_on_common`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org