You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/01 14:45:06 UTC

[GitHub] spark pull request #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/22600

    [SPARK-25578][BUILD] Update to Scala 2.12.7

    ## What changes were proposed in this pull request?
    
    Update to Scala 2.12.7. See https://issues.apache.org/jira/browse/SPARK-25578 for why.
    
    ## How was this patch tested?
    
    Existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-25578

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22600
    
----
commit 1e64cdff5665f5387157d1efe5be0520c4869b96
Author: Sean Owen <se...@...>
Date:   2018-10-01T14:44:11Z

    Update to Scala 2.12.7

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    @wangyum sounds good. I opened https://github.com/apache/spark/pull/23218


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3603/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    Merged to master/2.4


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    **[Test build #96817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96817/testReport)** for PR 22600 at commit [`1e64cdf`](https://github.com/apache/spark/commit/1e64cdff5665f5387157d1efe5be0520c4869b96).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22600


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    2.12.8 is out. Do we need to upgrade to 2.12.8?
    2.12.8 fixes two regressions that appeared in 2.12.7:
    ```
    Don't reject views with result types which are TypeVars (#7295)
    Don't emit static forwarders (which simplify the use of methods in top-level objects from Java) for bridge methods (#7469)
    ```
    More details: https://github.com/scala/scala/releases/tag/v2.12.8


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    **[Test build #96817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96817/testReport)** for PR 22600 at commit [`1e64cdf`](https://github.com/apache/spark/commit/1e64cdff5665f5387157d1efe5be0520c4869b96).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22600: [SPARK-25578][BUILD] Update to Scala 2.12.7

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22600
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96817/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org