[GitHub] [spark] rednaxelafx commented on a change in pull request #24735: [SPARK-27871][SQL] LambdaVariable should use per-query unique IDs instead of globally unique IDs

[GitBox <gi...@apache.org>]

rednaxelafx commented on a change in pull request #24735: [SPARK-27871][SQL] LambdaVariable should use per-query unique IDs instead of globally unique IDs
URL: https://github.com/apache/spark/pull/24735#discussion_r288692135
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetOptimizationSuite.scala
 ##########
 @@ -166,4 +164,42 @@ class DatasetOptimizationSuite extends QueryTest with SharedSQLContext {
       checkAnswer(df, Seq(Row("1"), Row("2"), Row("3")))
     }
   }
+
+  test("SPARK-27871: Dataset encoder should benefit from codegen cache") {
+    def checkCodegenCache(createDataset: () => Dataset[_]): Unit = {
+      val count1 = CodegenMetrics.METRIC_COMPILATION_TIME.getCount()
 
 Review comment:
   My earlier PR that added the whole-stage codegen ID used another metric for the same purpose:
   https://github.com/apache/spark/commit/e57f394818b0a62f99609e1032fede7e981f306f#diff-0314224342bb8c30143ab784b3805d19R296
   
   Should we try to make them use the exact same logic for checking whether or not codegen cache was hit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org