You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2009/05/18 22:53:45 UTC
[jira] Created: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Fix fDMI and OBL findbugs in packages hdfs and metrics
------------------------------------------------------
Key: HADOOP-5864
URL: https://issues.apache.org/jira/browse/HADOOP-5864
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Hairong Kuang
Fix For: 0.21.0
This issue is to fix the following findbugs:
DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Description:
This issue is to fix the following findbugs:
DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
was:
This issue is to fix the following findbugs:
DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
Assignee: Hairong Kuang
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix DMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Summary: Fix DMI and OBL findbugs in packages hdfs and metrics (was: Fix fDMI and OBL findbugs in packages hdfs and metrics)
> Fix DMI and OBL findbugs in packages hdfs and metrics
> -----------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5864) Fix fDMI and OBL findbugs in
packages hdfs and metrics
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711964#action_12711964 ]
Hadoop QA commented on HADOOP-5864:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408499/findBugs1.patch
against trunk revision 777330.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 release audit. The applied patch generated 492 release audit warnings (more than the trunk's current 491 warnings).
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/377/console
This message is automatically generated.
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5864) Fix fDMI and OBL findbugs in
packages hdfs and metrics
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710526#action_12710526 ]
Suresh Srinivas commented on HADOOP-5864:
-----------------------------------------
+1
Please add a brief comment in findbugsExcludeFile.xml to describe the reason for exclusion. Also creating a bug to track getting rid of copyBytes version that closes the streams in the method instead of the caller of the method would be nice.
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix DMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this.
> Fix DMI and OBL findbugs in packages hdfs and metrics
> -----------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Attachment: findBugs.patch
OBLs reported in FSDataset are not real bugs. So this patch put them in the findbugs exclude file. This patch fix the rest of the bugs. It also fixed improper handling of streams in FSShell and DatanodeBlockInfo.
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Status: Patch Available (was: Open)
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Status: Open (was: Patch Available)
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5864) Fix DMI and OBL findbugs in
packages hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714620#action_12714620 ]
Hairong Kuang commented on HADOOP-5864:
---------------------------------------
HADOOP-5943 is filed to deprecate copyBytes versions that close the pass-in streams.
> Fix DMI and OBL findbugs in packages hdfs and metrics
> -----------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Attachment: findBugs2.patch
Resubmit the patch to be synced with the trunk.
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Status: Patch Available (was: Open)
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5864) Fix DMI and OBL findbugs in
packages hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714609#action_12714609 ]
Hairong Kuang commented on HADOOP-5864:
---------------------------------------
ant testpatch result:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
All core tests were passed except for TestJobHistory reported in HADOOP-5920.
> Fix DMI and OBL findbugs in packages hdfs and metrics
> -----------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch, findBugs2.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5864) Fix fDMI and OBL findbugs in packages
hdfs and metrics
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5864:
----------------------------------
Attachment: findBugs1.patch
This patch additionally adds a comment in the findbugs exclude file. Once this patch is committed, I will file a jira to deprecate the method copyBytes that allows to close the streams in the method instead of the caller of the method
> Fix fDMI and OBL findbugs in packages hdfs and metrics
> ------------------------------------------------------
>
> Key: HADOOP-5864
> URL: https://issues.apache.org/jira/browse/HADOOP-5864
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: findBugs.patch, findBugs1.patch
>
>
> This issue is to fix the following findbugs:
> DMI in org.apache.hadoop.hdfs.server.namenode.INodeDirectory.getExistingPathINodes(byte[][], INode[])
> OBL in org.apache.hadoop.hdfs.server.datanode.DataStorage.linkBlocks(File, File, int)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.createBlockWriteStreams(File, File)
> OBL in org.apache.hadoop.hdfs.server.datanode.FSDataset.getTmpInputStreams(Block, long, long)
> OBL in org.apache.hadoop.metrics.ContextFactory.setAttributes()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.