You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/11/19 22:23:38 UTC
[maven-site-plugin] 02/03: [MSITE-912] Reporting plugins never executed when more than one locale is configured
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch doxia-sitetools-2.0.0-M4
in repository https://gitbox.apache.org/repos/asf/maven-site-plugin.git
commit 60403c80e4bc0d34a2884dae4213f72e58360475
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Nov 19 23:22:16 2022 +0100
[MSITE-912] Reporting plugins never executed when more than one locale is configured
TODO add/extend IT
---
.../maven/plugins/site/render/AbstractSiteRenderingMojo.java | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java b/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java
index 1f93053c..921ac25f 100644
--- a/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java
+++ b/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java
@@ -357,11 +357,8 @@ public abstract class AbstractSiteRenderingMojo extends AbstractSiteDescriptorMo
protected Map<String, MavenReport> locateReports( List<MavenReportExecution> reports,
Map<String, DocumentRenderer> documents, Locale locale )
{
- // copy Collection to prevent ConcurrentModificationException
- List<MavenReportExecution> filtered = new ArrayList<>( reports );
-
Map<String, MavenReport> reportsByOutputName = new LinkedHashMap<>();
- for ( MavenReportExecution mavenReportExecution : filtered )
+ for ( MavenReportExecution mavenReportExecution : reports )
{
MavenReport report = mavenReportExecution.getMavenReport();
@@ -379,8 +376,6 @@ public abstract class AbstractSiteRenderingMojo extends AbstractSiteDescriptorMo
getLog().info( "Skipped \"" + report.getName( locale ) + "\" report" + reportMojoInfo + ", file \""
+ outputName + "\" already exists." );
-
- reports.remove( mavenReportExecution );
}
else
{