You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Joe Witt <jo...@gmail.com> on 2014/12/10 13:41:16 UTC
Question about patches
Mentors,
For NIFI-154 we received a patch via Jira. I read that this is inherently
considered a submission that is useable but that was on the webpage of
another apache project. Is this correct? Do we need to request ICLAs
before we can use these things?
Just want to make sure the process of accepting patches is understood.
Thanks
Joe
Re: Question about patches
Posted by Benson Margulies <bi...@gmail.com>.
On Wed, Dec 10, 2014 at 8:32 PM, Joe Witt <jo...@gmail.com> wrote:
> Thanks Billie. The accumulo page and references to Kafka's docs on this
> subject were excellent.
>
> Your Github comment reminds me that
> https://github.com/apache/incubator-nifi
> does not exist yet.
>
> I do see that the Git INFRA ticket didn't ask for Github mirroring
> specifically: https://issues.apache.org/jira/browse/INFRA-8707
>
> Is this something I can request or does it need to come from an mentor?
>
I just asked @infra if it requires its own JIRA.
>
> Thanks
> Joe
>
> On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org>
> wrote:
>
> > No, an ICLA is not necessary for contributions submitted through ASF
> > infrastructure. See the definition of Contribution and the section on
> > Submission of Contributions in the Apache License v. 2.0 (
> > http://www.apache.org/licenses/LICENSE-2.0).
> >
> > If we want to be able to accept GitHub pull requests, the process is not
> as
> > clear. The first couple of paragraphs under "Reviewing contributor
> > changes" on http://accumulo.apache.org/git.html are worth reading. Also
> > we
> > would need to make sure pull requests trigger an email to the dev list --
> > not sure if that is set up by default, or if we have to request it.
> >
> > On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
> >
> > > Mentors,
> > >
> > > For NIFI-154 we received a patch via Jira. I read that this is
> > inherently
> > > considered a submission that is useable but that was on the webpage of
> > > another apache project. Is this correct? Do we need to request ICLAs
> > > before we can use these things?
> > >
> > > Just want to make sure the process of accepting patches is understood.
> > >
> > > Thanks
> > > Joe
> > >
> >
>
Re: Question about patches
Posted by Joe Witt <jo...@gmail.com>.
Thanks Billie. The accumulo page and references to Kafka's docs on this
subject were excellent.
Your Github comment reminds me that https://github.com/apache/incubator-nifi
does not exist yet.
I do see that the Git INFRA ticket didn't ask for Github mirroring
specifically: https://issues.apache.org/jira/browse/INFRA-8707
Is this something I can request or does it need to come from an mentor?
Thanks
Joe
On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org> wrote:
> No, an ICLA is not necessary for contributions submitted through ASF
> infrastructure. See the definition of Contribution and the section on
> Submission of Contributions in the Apache License v. 2.0 (
> http://www.apache.org/licenses/LICENSE-2.0).
>
> If we want to be able to accept GitHub pull requests, the process is not as
> clear. The first couple of paragraphs under "Reviewing contributor
> changes" on http://accumulo.apache.org/git.html are worth reading. Also
> we
> would need to make sure pull requests trigger an email to the dev list --
> not sure if that is set up by default, or if we have to request it.
>
> On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
>
> > Mentors,
> >
> > For NIFI-154 we received a patch via Jira. I read that this is
> inherently
> > considered a submission that is useable but that was on the webpage of
> > another apache project. Is this correct? Do we need to request ICLAs
> > before we can use these things?
> >
> > Just want to make sure the process of accepting patches is understood.
> >
> > Thanks
> > Joe
> >
>
Re: Question about patches
Posted by Jake Visser <ja...@nightrise.com.au>.
Hi there,
Sorry I was meaning to send an email about the patch as well but time got away from me. The patch was more a way to discuss if this is the "right way" to do it.
I would be more than happy to become a committer and submit right to git / close out the tickets if its easier.
Cheers
Jake
Sent from my phone.
> On 11 Dec 2014, at 05:14, Benson Margulies <bi...@gmail.com> wrote:
>
> Other communities are using a workflow in which a JIRA linked to a PR is
> good enough (e.g. Lucene), and there's an integration where a commit
> comment with a PR # closes the PR.
>
> So if you want that stuff, we should ask infra@ about it.
>
>
>> On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org> wrote:
>>
>> No, an ICLA is not necessary for contributions submitted through ASF
>> infrastructure. See the definition of Contribution and the section on
>> Submission of Contributions in the Apache License v. 2.0 (
>> http://www.apache.org/licenses/LICENSE-2.0).
>>
>> If we want to be able to accept GitHub pull requests, the process is not as
>> clear. The first couple of paragraphs under "Reviewing contributor
>> changes" on http://accumulo.apache.org/git.html are worth reading. Also
>> we
>> would need to make sure pull requests trigger an email to the dev list --
>> not sure if that is set up by default, or if we have to request it.
>>
>>> On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
>>>
>>> Mentors,
>>>
>>> For NIFI-154 we received a patch via Jira. I read that this is
>> inherently
>>> considered a submission that is useable but that was on the webpage of
>>> another apache project. Is this correct? Do we need to request ICLAs
>>> before we can use these things?
>>>
>>> Just want to make sure the process of accepting patches is understood.
>>>
>>> Thanks
>>> Joe
>>>
>>
Re: Question about patches
Posted by Sean Busbey <bu...@cloudera.com>.
I think the integration between the PR (esp comments) and the notification
list was an optional component last time I heard about it. If we're going
to take regular contributions directly from github, we should make sure
that is turned on so that the activity hits some ASF mailing list (though
preferably not dev@nifi).
On Wed, Dec 10, 2014 at 9:10 PM, Joe Witt <jo...@gmail.com> wrote:
> Thanks - if you think we're safe to accept contribs both as patches and PRs
> provided it is tied to a valid Jira ticket in NIFI- then that sounds good
> to me.
>
> Thanks
> Joe
>
> On Wed, Dec 10, 2014 at 10:08 PM, Benson Margulies <bi...@gmail.com>
> wrote:
>
> > Lucene encourages people to make a JIRA to go with their PR. However, I
> can
> > find you a legal JIRA that makes it quite clear that for small
> > contributions there is no problem here.
> >
> >
> > On Wed, Dec 10, 2014 at 9:54 PM, Joe Witt <jo...@gmail.com> wrote:
> >
> > > Benson,
> > >
> > > I think we should support contributions from folks both as patches and
> > via
> > > pull requests. I am inclined to think we should ask infra to add the
> > > integration hook which will close out the PR.
> > >
> > > That said, as Billie noted there seems to be some concern over whether
> a
> > PR
> > > from Github provides sufficient legal clarity. Did Lucene get beyond
> > that?
> > >
> > > Thanks
> > > Joe
> > >
> > > On Wed, Dec 10, 2014 at 1:12 PM, Benson Margulies <
> bimargulies@gmail.com
> > >
> > > wrote:
> > >
> > > > Other communities are using a workflow in which a JIRA linked to a PR
> > is
> > > > good enough (e.g. Lucene), and there's an integration where a commit
> > > > comment with a PR # closes the PR.
> > > >
> > > > So if you want that stuff, we should ask infra@ about it.
> > > >
> > > >
> > > > On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org>
> > > > wrote:
> > > >
> > > > > No, an ICLA is not necessary for contributions submitted through
> ASF
> > > > > infrastructure. See the definition of Contribution and the section
> > on
> > > > > Submission of Contributions in the Apache License v. 2.0 (
> > > > > http://www.apache.org/licenses/LICENSE-2.0).
> > > > >
> > > > > If we want to be able to accept GitHub pull requests, the process
> is
> > > not
> > > > as
> > > > > clear. The first couple of paragraphs under "Reviewing contributor
> > > > > changes" on http://accumulo.apache.org/git.html are worth reading.
> > > Also
> > > > > we
> > > > > would need to make sure pull requests trigger an email to the dev
> > list
> > > --
> > > > > not sure if that is set up by default, or if we have to request it.
> > > > >
> > > > > On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com>
> > wrote:
> > > > >
> > > > > > Mentors,
> > > > > >
> > > > > > For NIFI-154 we received a patch via Jira. I read that this is
> > > > > inherently
> > > > > > considered a submission that is useable but that was on the
> webpage
> > > of
> > > > > > another apache project. Is this correct? Do we need to request
> > > ICLAs
> > > > > > before we can use these things?
> > > > > >
> > > > > > Just want to make sure the process of accepting patches is
> > > understood.
> > > > > >
> > > > > > Thanks
> > > > > > Joe
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
Sean
Re: Question about patches
Posted by Joe Witt <jo...@gmail.com>.
Thanks - if you think we're safe to accept contribs both as patches and PRs
provided it is tied to a valid Jira ticket in NIFI- then that sounds good
to me.
Thanks
Joe
On Wed, Dec 10, 2014 at 10:08 PM, Benson Margulies <bi...@gmail.com>
wrote:
> Lucene encourages people to make a JIRA to go with their PR. However, I can
> find you a legal JIRA that makes it quite clear that for small
> contributions there is no problem here.
>
>
> On Wed, Dec 10, 2014 at 9:54 PM, Joe Witt <jo...@gmail.com> wrote:
>
> > Benson,
> >
> > I think we should support contributions from folks both as patches and
> via
> > pull requests. I am inclined to think we should ask infra to add the
> > integration hook which will close out the PR.
> >
> > That said, as Billie noted there seems to be some concern over whether a
> PR
> > from Github provides sufficient legal clarity. Did Lucene get beyond
> that?
> >
> > Thanks
> > Joe
> >
> > On Wed, Dec 10, 2014 at 1:12 PM, Benson Margulies <bimargulies@gmail.com
> >
> > wrote:
> >
> > > Other communities are using a workflow in which a JIRA linked to a PR
> is
> > > good enough (e.g. Lucene), and there's an integration where a commit
> > > comment with a PR # closes the PR.
> > >
> > > So if you want that stuff, we should ask infra@ about it.
> > >
> > >
> > > On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org>
> > > wrote:
> > >
> > > > No, an ICLA is not necessary for contributions submitted through ASF
> > > > infrastructure. See the definition of Contribution and the section
> on
> > > > Submission of Contributions in the Apache License v. 2.0 (
> > > > http://www.apache.org/licenses/LICENSE-2.0).
> > > >
> > > > If we want to be able to accept GitHub pull requests, the process is
> > not
> > > as
> > > > clear. The first couple of paragraphs under "Reviewing contributor
> > > > changes" on http://accumulo.apache.org/git.html are worth reading.
> > Also
> > > > we
> > > > would need to make sure pull requests trigger an email to the dev
> list
> > --
> > > > not sure if that is set up by default, or if we have to request it.
> > > >
> > > > On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com>
> wrote:
> > > >
> > > > > Mentors,
> > > > >
> > > > > For NIFI-154 we received a patch via Jira. I read that this is
> > > > inherently
> > > > > considered a submission that is useable but that was on the webpage
> > of
> > > > > another apache project. Is this correct? Do we need to request
> > ICLAs
> > > > > before we can use these things?
> > > > >
> > > > > Just want to make sure the process of accepting patches is
> > understood.
> > > > >
> > > > > Thanks
> > > > > Joe
> > > > >
> > > >
> > >
> >
>
Re: Question about patches
Posted by Benson Margulies <bi...@gmail.com>.
Lucene encourages people to make a JIRA to go with their PR. However, I can
find you a legal JIRA that makes it quite clear that for small
contributions there is no problem here.
On Wed, Dec 10, 2014 at 9:54 PM, Joe Witt <jo...@gmail.com> wrote:
> Benson,
>
> I think we should support contributions from folks both as patches and via
> pull requests. I am inclined to think we should ask infra to add the
> integration hook which will close out the PR.
>
> That said, as Billie noted there seems to be some concern over whether a PR
> from Github provides sufficient legal clarity. Did Lucene get beyond that?
>
> Thanks
> Joe
>
> On Wed, Dec 10, 2014 at 1:12 PM, Benson Margulies <bi...@gmail.com>
> wrote:
>
> > Other communities are using a workflow in which a JIRA linked to a PR is
> > good enough (e.g. Lucene), and there's an integration where a commit
> > comment with a PR # closes the PR.
> >
> > So if you want that stuff, we should ask infra@ about it.
> >
> >
> > On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org>
> > wrote:
> >
> > > No, an ICLA is not necessary for contributions submitted through ASF
> > > infrastructure. See the definition of Contribution and the section on
> > > Submission of Contributions in the Apache License v. 2.0 (
> > > http://www.apache.org/licenses/LICENSE-2.0).
> > >
> > > If we want to be able to accept GitHub pull requests, the process is
> not
> > as
> > > clear. The first couple of paragraphs under "Reviewing contributor
> > > changes" on http://accumulo.apache.org/git.html are worth reading.
> Also
> > > we
> > > would need to make sure pull requests trigger an email to the dev list
> --
> > > not sure if that is set up by default, or if we have to request it.
> > >
> > > On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
> > >
> > > > Mentors,
> > > >
> > > > For NIFI-154 we received a patch via Jira. I read that this is
> > > inherently
> > > > considered a submission that is useable but that was on the webpage
> of
> > > > another apache project. Is this correct? Do we need to request
> ICLAs
> > > > before we can use these things?
> > > >
> > > > Just want to make sure the process of accepting patches is
> understood.
> > > >
> > > > Thanks
> > > > Joe
> > > >
> > >
> >
>
Re: Question about patches
Posted by Joe Witt <jo...@gmail.com>.
Benson,
I think we should support contributions from folks both as patches and via
pull requests. I am inclined to think we should ask infra to add the
integration hook which will close out the PR.
That said, as Billie noted there seems to be some concern over whether a PR
from Github provides sufficient legal clarity. Did Lucene get beyond that?
Thanks
Joe
On Wed, Dec 10, 2014 at 1:12 PM, Benson Margulies <bi...@gmail.com>
wrote:
> Other communities are using a workflow in which a JIRA linked to a PR is
> good enough (e.g. Lucene), and there's an integration where a commit
> comment with a PR # closes the PR.
>
> So if you want that stuff, we should ask infra@ about it.
>
>
> On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org>
> wrote:
>
> > No, an ICLA is not necessary for contributions submitted through ASF
> > infrastructure. See the definition of Contribution and the section on
> > Submission of Contributions in the Apache License v. 2.0 (
> > http://www.apache.org/licenses/LICENSE-2.0).
> >
> > If we want to be able to accept GitHub pull requests, the process is not
> as
> > clear. The first couple of paragraphs under "Reviewing contributor
> > changes" on http://accumulo.apache.org/git.html are worth reading. Also
> > we
> > would need to make sure pull requests trigger an email to the dev list --
> > not sure if that is set up by default, or if we have to request it.
> >
> > On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
> >
> > > Mentors,
> > >
> > > For NIFI-154 we received a patch via Jira. I read that this is
> > inherently
> > > considered a submission that is useable but that was on the webpage of
> > > another apache project. Is this correct? Do we need to request ICLAs
> > > before we can use these things?
> > >
> > > Just want to make sure the process of accepting patches is understood.
> > >
> > > Thanks
> > > Joe
> > >
> >
>
Re: Question about patches
Posted by Benson Margulies <bi...@gmail.com>.
Other communities are using a workflow in which a JIRA linked to a PR is
good enough (e.g. Lucene), and there's an integration where a commit
comment with a PR # closes the PR.
So if you want that stuff, we should ask infra@ about it.
On Wed, Dec 10, 2014 at 10:30 AM, Billie Rinaldi <bi...@apache.org> wrote:
> No, an ICLA is not necessary for contributions submitted through ASF
> infrastructure. See the definition of Contribution and the section on
> Submission of Contributions in the Apache License v. 2.0 (
> http://www.apache.org/licenses/LICENSE-2.0).
>
> If we want to be able to accept GitHub pull requests, the process is not as
> clear. The first couple of paragraphs under "Reviewing contributor
> changes" on http://accumulo.apache.org/git.html are worth reading. Also
> we
> would need to make sure pull requests trigger an email to the dev list --
> not sure if that is set up by default, or if we have to request it.
>
> On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
>
> > Mentors,
> >
> > For NIFI-154 we received a patch via Jira. I read that this is
> inherently
> > considered a submission that is useable but that was on the webpage of
> > another apache project. Is this correct? Do we need to request ICLAs
> > before we can use these things?
> >
> > Just want to make sure the process of accepting patches is understood.
> >
> > Thanks
> > Joe
> >
>
Re: Question about patches
Posted by Billie Rinaldi <bi...@apache.org>.
No, an ICLA is not necessary for contributions submitted through ASF
infrastructure. See the definition of Contribution and the section on
Submission of Contributions in the Apache License v. 2.0 (
http://www.apache.org/licenses/LICENSE-2.0).
If we want to be able to accept GitHub pull requests, the process is not as
clear. The first couple of paragraphs under "Reviewing contributor
changes" on http://accumulo.apache.org/git.html are worth reading. Also we
would need to make sure pull requests trigger an email to the dev list --
not sure if that is set up by default, or if we have to request it.
On Wed, Dec 10, 2014 at 4:41 AM, Joe Witt <jo...@gmail.com> wrote:
> Mentors,
>
> For NIFI-154 we received a patch via Jira. I read that this is inherently
> considered a submission that is useable but that was on the webpage of
> another apache project. Is this correct? Do we need to request ICLAs
> before we can use these things?
>
> Just want to make sure the process of accepting patches is understood.
>
> Thanks
> Joe
>