You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/15 09:02:15 UTC
[GitHub] [hudi] mabin001 opened a new pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
mabin001 opened a new pull request #1832:
URL: https://github.com/apache/hudi/pull/1832
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
This pull request improves the code.
when list is parameter，We should determine if the list is empty before calling the method。
what's your opinion？
## Brief change log
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mabin001 closed pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
mabin001 closed pull request #1832:
URL: https://github.com/apache/hudi/pull/1832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mabin001 commented on pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
mabin001 commented on pull request #1832:
URL: https://github.com/apache/hudi/pull/1832#issuecomment-660753692
> > > @mabin001 Thanks for you contributing, `addPartitionsToTable` and `updatePartitionsToTable ` are good to handle empty partitions and it is a more proper way IMHO.
> >
> >
> > I agree with you about `addPartitionsToTable` and `updatePartitionsToTable ` are good to handle empty partitions，but We should determine the list is empty or not empty before calling the method。So, i think i can delete the code of this
> > 
> > 
> > .
> > TestHiveSyncTool#testBasicSync
> > 
> > can delete too.
>
> Thanks for the explanation @mabin001 . In fact I do think current solution is more reasonable and cleaner IMHO, other callers would call the method without checking the empty and let the method to check empty. If you check empty before calling the method, there will be a lot of duplicate code.
ok, i get it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mabin001 closed pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
mabin001 closed pull request #1832:
URL: https://github.com/apache/hudi/pull/1832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mabin001 closed pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
mabin001 closed pull request #1832:
URL: https://github.com/apache/hudi/pull/1832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mabin001 commented on pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
mabin001 commented on pull request #1832:
URL: https://github.com/apache/hudi/pull/1832#issuecomment-658655885
retest it please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mabin001 commented on pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
mabin001 commented on pull request #1832:
URL: https://github.com/apache/hudi/pull/1832#issuecomment-659961734
> @mabin001 Thanks for you contributing, `addPartitionsToTable` and `updatePartitionsToTable ` are good to handle empty partitions and it is a more proper way IMHO.
I agree with you about `addPartitionsToTable` and `updatePartitionsToTable ` are good to handle empty partitions，but We should determine the list is empty or not empty before calling the method。So, i think i can delete the code of this
.
TestHiveSyncTool#testBasicSync
can delete too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1832: [HUDI-1099]: improve quality of the code calling the method.HiveSyncTool#syncPartitions
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1832:
URL: https://github.com/apache/hudi/pull/1832#issuecomment-660050240
> > @mabin001 Thanks for you contributing, `addPartitionsToTable` and `updatePartitionsToTable ` are good to handle empty partitions and it is a more proper way IMHO.
>
> I agree with you about `addPartitionsToTable` and `updatePartitionsToTable ` are good to handle empty partitions，but We should determine the list is empty or not empty before calling the method。So, i think i can delete the code of this
> 
> 
> .
> TestHiveSyncTool#testBasicSync
> 
> can delete too.
Thanks for the explanation @mabin001 . In fact I do think current solution is more reasonable and cleaner IMHO, other callers would call the method without checking the empty and let the method to check empty. If you check empty before calling the method, there will be a lot of duplicate code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org