You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/09 19:38:38 UTC

[GitHub] [spark] rdblue opened a new pull request #24570: [SPARK-24923][SQL] Implement v2 CreateTableAsSelect

rdblue opened a new pull request #24570: [SPARK-24923][SQL] Implement v2 CreateTableAsSelect
URL: https://github.com/apache/spark/pull/24570
 
 
   ## What changes were proposed in this pull request?
   
   This adds a v2 implementation for CTAS queries
   
   * Update the SQL parser to parse CREATE queries using multi-part identifiers
   * Update `CheckAnalysis` to validate partitioning references with the CTAS query schema
   * Add `CreateTableAsSelect` v2 logical plan and `CreateTableAsSelectExec` v2 physical plan
   * Update create conversion from `CreateTableAsSelectStatement` to support the new v2 logical plan
   * Update `DataSourceV2Strategy` to convert v2 CTAS logical plan to the new physical plan
   * Add `findNestedField` to `StructType` to support reference validation
   
   ## How was this patch tested?
   
   * Add a test suite `CreateTablePartitioningValidationSuite` for new analysis checks
   * Update catalyst `DDLParserSuite` to use multi-part identifiers (`Seq[String]`)
   * Add test cases to `PlanResolutionSuite` for v2 CTAS: known catalog and v2 implementation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org