You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/14 23:50:03 UTC

[GitHub] [apisix] moonming commented on a change in pull request #2424: feat: In dns parse, the value of `resolvers` is allowed to be empty

moonming commented on a change in pull request #2424:
URL: https://github.com/apache/apisix/pull/2424#discussion_r505079428



##########
File path: t/core/utils.t
##########
@@ -68,3 +68,19 @@ qr/random seed \d+\ntwice: false/
 GET /t
 --- no_error_log
 [error]
+

Review comment:
       The test case did not cover empty configuration of resolver




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org