You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Antoine Levy Lambert <an...@gmx.de> on 2014/07/09 23:42:57 UTC
Re: [1/8] make it compile under Java5 (1.5.0_22-b03)
Hello Jan,
I was wondering why you are interested into make it compile under Java5 (1.5.0_22-b03) ?
Note, I am just curious, not critical.
It looks like this particular Java version is very demanding concerning the presence of the final keyword next to method parameters or maybe also for variables which are in the scope of nested classes.
I am programming in scala these days with its insistence on using val (immutable variables) wherever possible so I see a connection.
Antoine
On Jul 4, 2014, at 9:15 AM, jhm@apache.org wrote:
> Repository: ant
> Updated Branches:
> refs/heads/master 1b76f1b6d -> 789422e13
>
>
> http://git-wip-us.apache.org/repos/asf/ant/blob/13f6d98c/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java b/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> index 36024ec..e8df272 100644
> --- a/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> +++ b/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> @@ -70,7 +70,7 @@ public class SymbolicLinkUtils {
> * @return true if the file is a symbolic link.
> * @throws IOException on error.
> */
> - public boolean isSymbolicLink(File file) throws IOException {
> + public boolean isSymbolicLink(final File file) throws IOException {
> return isSymbolicLink(file.getParentFile(), file.getName());
> }
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [1/8] make it compile under Java5 (1.5.0_22-b03)
Posted by Stefan Bodewig <bo...@apache.org>.
On 2014-07-09, Antoine Levy Lambert wrote:
> I was wondering why you are interested into make it compile under Java5 (1.5.0_22-b03) ?
I think it is very reasonable to make things compile on the versions we
claim to support :-)
> It looks like this particular Java version is very demanding
> concerning the presence of the final keyword next to method parameters
> or maybe also for variables which are in the scope of nested classes.
Not at all. The commit has introduced quite a few changes that are not
related to Java5 AFAICT. Might by Jan's IDE settings. It added TABs to
some files, introduced final where possible (but not required) and even
introduced a bug in <tar> that fortunately was found by the CIs - but
lost in the noise of other test failures.
Reviewing those last few commits is on my TODO list, hope to get around
to it on the weekend.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: [1/8] make it compile under Java5 (1.5.0_22-b03)
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
Because Java5 is the lowest specified java version we support/require:
http://ant.apache.org/faq.html#java-version
Jan
> -----Ursprüngliche Nachricht-----
> Von: Antoine Levy Lambert [mailto:antoine@gmx.de]
> Gesendet: Mittwoch, 9. Juli 2014 23:43
> An: dev@ant.apache.org
> Betreff: Re: [1/8] make it compile under Java5 (1.5.0_22-b03)
>
> Hello Jan,
>
> I was wondering why you are interested into make it compile under Java5
> (1.5.0_22-b03) ?
>
> Note, I am just curious, not critical.
>
> It looks like this particular Java version is very demanding concerning
> the presence of the final keyword next to method parameters or maybe
> also for variables which are in the scope of nested classes.
>
> I am programming in scala these days with its insistence on using val
> (immutable variables) wherever possible so I see a connection.
>
> Antoine
>
> On Jul 4, 2014, at 9:15 AM, jhm@apache.org wrote:
>
> > Repository: ant
> > Updated Branches:
> > refs/heads/master 1b76f1b6d -> 789422e13
> >
> >
> > http://git-wip-
> us.apache.org/repos/asf/ant/blob/13f6d98c/src/main/org/
> > apache/tools/ant/util/SymbolicLinkUtils.java
> > ---------------------------------------------------------------------
> -
> > diff --git
> a/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> > b/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> > index 36024ec..e8df272 100644
> > --- a/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> > +++ b/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
> > @@ -70,7 +70,7 @@ public class SymbolicLinkUtils {
> > * @return true if the file is a symbolic link.
> > * @throws IOException on error.
> > */
> > - public boolean isSymbolicLink(File file) throws IOException {
> > + public boolean isSymbolicLink(final File file) throws
> IOException
> > + {
> > return isSymbolicLink(file.getParentFile(), file.getName());
> > }
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org