[GitHub] Tresdon commented on issue #4725: Add "Published" feature to dashboards

[GitBox <gi...@apache.org>]

Tresdon commented on issue #4725: Add "Published" feature to dashboards
URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-387877549
 
 
   @mistercrunch This pull request should be finished now, let me know what you think. One thing I didn't mention was that this doesn't get rid of the `self.has_all_datasource_access()` check on dashboards and it still validates that user has access to all charts in the particular dashboard if they don't have access to all datasources. So right now for gamma users this is an additional constraint on top of them having access to all charts which we may want to change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org