[GitHub] [kafka] kkonstantine commented on a change in pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster

[GitBox <gi...@apache.org>]

kkonstantine commented on a change in pull request #11619:
URL: https://github.com/apache/kafka/pull/11619#discussion_r776089831



##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##########
@@ -135,6 +135,8 @@ private void doStart() {
         putIfAbsent(brokerConfig, KafkaConfig.GroupInitialRebalanceDelayMsProp(), 0);
         putIfAbsent(brokerConfig, KafkaConfig.OffsetsTopicReplicationFactorProp(), (short) brokers.length);
         putIfAbsent(brokerConfig, KafkaConfig.AutoCreateTopicsEnableProp(), false);
+        // reduce the size of the log cleaner map to reduce test memory usage
+        putIfAbsent(brokerConfig, KafkaConfig.LogCleanerDedupeBufferSizeProp(), "2097152");

Review comment:
       Makes sense. Just wanted to suggest making it more readable and coincidentally I saw this would make it also same as the one in the equivalent streams class: 
   
   https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java#L94




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org