You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/02/04 11:22:45 UTC

Re: [PR] MetaStoreManagerFactory: make purgeRealms() return purge results [polaris]

adutra commented on PR #889:
URL: https://github.com/apache/polaris/pull/889#issuecomment-2633617023

   PR rebased. 
   
   With the revert from `RealmId` back to `RealmContext`, the scope of this PR faded to almost nothing. Indeed, `RealmContext` is even worse than `RealmId` as a map key or set element, because all its instances are just lambdas, and thus do not have any strong contract for `equals()` and `hashCode()`. It is therefore really a bad idea to use those in _any_ collection.
   
   The new scope of this PR is now focused around making the `purgeRealms` method return the purge results.
   
   @snazy @collado-mike @eric-maynard can an I have another review please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org