You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jpountz (via GitHub)" <gi...@apache.org> on 2025/08/08 03:35:06 UTC
[I] Seal the BitSet class? [lucene]
jpountz opened a new issue, #15038:
URL: https://github.com/apache/lucene/issues/15038
### Description
`BitSet` is used in some performance-critical places. We should seal this class so that it only allows `FixedBitSet` and `SparseFixedBitSet` as sub-classes, to prevent applications from mistakenly hurting performance by creating other sub-classes that could make call sites of `BitSet#get`, `BitSet#nextSetBit` and others polymorphic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Seal the BitSet class [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on issue #15038:
URL: https://github.com/apache/lucene/issues/15038#issuecomment-3168144457
Sure, feel free to give it a try. Be warned that this change may be controversial though, so it may not be merged even if the change is perfectly fine from the code perspective if the implications on users are deemed not good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Seal the BitSet class [lucene]
Posted by "priorigratia (via GitHub)" <gi...@apache.org>.
priorigratia commented on issue #15038:
URL: https://github.com/apache/lucene/issues/15038#issuecomment-3168062393
hi @jpountz can I work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org