[GitHub] [iceberg] jackye1995 commented on a diff in pull request #4953: Core, API: Replace unneccessary uses of hash with hashCode

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #4953:
URL: https://github.com/apache/iceberg/pull/4953#discussion_r889075617


##########
api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java:
##########
@@ -172,7 +172,7 @@ public boolean equals(Object o) {
 
   @Override
   public int hashCode() {
-    return Objects.hash(wrapperSet);

Review Comment:
   I think we should instead suppress the warning, because:
   1. this might change the hashcode of the class object? We should verify
   2. if more fields are added, we need to get back to use `Objects.hash` again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org