You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Daniel Halperin (JIRA)" <ji...@apache.org> on 2016/11/07 17:06:58 UTC
[jira] [Updated] (BEAM-925) Findbugs doesn't pass in Dataflow
Runner
[ https://issues.apache.org/jira/browse/BEAM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Halperin updated BEAM-925:
---------------------------------
Description:
{code}
[INFO] Format-string method String.format(String, Object[]) called with format string "Cannot create output file at {}" wants 0 arguments but is given 1 in org.apache.beam.runners.dataflow.DataflowRunner.run(Pipeline) [org.apache.beam.runners.dataflow.DataflowRunner] At DataflowRunner.java:[line 578]
[INFO] Format-string method String.format(String, Object[]) called with format string "Location must be local or on Cloud Storage, got {}." wants 0 arguments but is given 1 in org.apache.beam.runners.dataflow.DataflowRunner.run(Pipeline) [org.apache.beam.runners.dataflow.DataflowRunner] At DataflowRunner.java:[line 567]
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsIterable defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsIterable] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsList defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsList] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMap] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMultimap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMultimap] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsSingleton defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsSingleton] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchWrite defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchWrite] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMap] In DataflowRunner.java
[INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMultimap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMultimap] In DataflowRunner.java
[INFO] Possible null pointer dereference of DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource.reader in org.apache.beam.runners.dataflow.internal.DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource.advance() [org.apache.beam.runners.dataflow.internal.DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource, org.apache.beam.runners.dataflow.internal.DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource] Dereferenced at DataflowUnboundedReadFromBoundedSource.java:[line 495]Known null at DataflowUnboundedReadFromBoundedSource.java:[line 491]
[INFO] Nullcheck of record at line 412 of value previously dereferenced in org.apache.beam.runners.dataflow.internal.IsmFormat$IsmRecordCoder.structuralValue(IsmFormat$IsmRecord) [org.apache.beam.runners.dataflow.internal.IsmFormat$IsmRecordCoder, org.apache.beam.runners.dataflow.internal.IsmFormat$IsmRecordCoder] At IsmFormat.java:[line 407]Redundant null check at IsmFormat.java:[line 412]
[INFO] org.apache.beam.runners.dataflow.util.MonitoringUtil$TimeStampComparator implements Comparator but not Serializable [org.apache.beam.runners.dataflow.util.MonitoringUtil$TimeStampComparator] At MonitoringUtil.java:[lines 131-142]
[INFO] Unread field: org.apache.beam.runners.dataflow.util.OutputReference.type; should this field be static? [org.apache.beam.runners.dataflow.util.OutputReference] At OutputReference.java:[line 30]
[INFO] org.apache.beam.runners.dataflow.util.RandomAccessData$UnsignedLexicographicalComparator implements Comparator but not Serializable [org.apache.beam.runners.dataflow.util.RandomAccessData$UnsignedLexicographicalComparator] At RandomAccessData.java:[lines 129-183]
[INFO] Boxing/unboxing to parse a primitive org.apache.beam.runners.dataflow.util.TimeUtil.fromCloudDuration(String) [org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil] At TimeUtil.java:[line 148]Another occurrence at TimeUtil.java:[line 151]
[INFO] Boxing/unboxing to parse a primitive org.apache.beam.runners.dataflow.util.TimeUtil.fromCloudTime(String) [org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil] At TimeUtil.java:[line 95]Another occurrence at TimeUtil.java:[line 96]Another occurrence at TimeUtil.java:[line 97]Another occurrence at TimeUtil.java:[line 98]Another occurrence at TimeUtil.java:[line 99]Another occurrence at TimeUtil.java:[line 100]Another occurrence at TimeUtil.java:[line 105]
[INFO]
{code}
was:
{code}
[INFO] AggregatorContainer$AggregatorInfo.accumulator not guarded against concurrent access; locked 71% of time [org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo] Unsynchronized access at AggregatorContainer.java:[line 80]Unsynchronized access at AggregatorContainer.java:[line 79]Unsynchronized access at AggregatorContainer.java:[line 81]Synchronized access at AggregatorContainer.java:[line 78]Synchronized access at AggregatorContainer.java:[line 79]Synchronized access at AggregatorContainer.java:[line 81]Synchronized access at AggregatorContainer.java:[line 81]Synchronized access at AggregatorContainer.java:[line 59]Synchronized access at AggregatorContainer.java:[line 62]Synchronized access at AggregatorContainer.java:[line 62]Synchronized access at AggregatorContainer.java:[line 60]Synchronized access at AggregatorContainer.java:[line 66]Synchronized access at AggregatorContainer.java:[line 66]
[INFO] bundle must be non-null but is marked as nullable [org.apache.beam.runners.direct.ExecutorServiceParallelExecutor] At ExecutorServiceParallelExecutor.java:[lines 185-186]
[INFO] Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.beam.runners.direct.ExecutorServiceParallelExecutor$MonitorRunnable.run() [org.apache.beam.runners.direct.ExecutorServiceParallelExecutor$MonitorRunnable] At ExecutorServiceParallelExecutor.java:[line 412]
[INFO] org.apache.beam.runners.direct.WatermarkCallbackExecutor$CallbackOrdering implements Comparator but not Serializable [org.apache.beam.runners.direct.WatermarkCallbackExecutor$CallbackOrdering] At WatermarkCallbackExecutor.java:[lines 132-138]
[INFO] org.apache.beam.runners.direct.WatermarkManager$WindowedValueByTimestampComparator implements Comparator but not Serializable [org.apache.beam.runners.direct.WatermarkManager$WindowedValueByTimestampComparator] At WatermarkManager.java:[lines 1380-1385]
[INFO]
{code}
> Findbugs doesn't pass in Dataflow Runner
> ----------------------------------------
>
> Key: BEAM-925
> URL: https://issues.apache.org/jira/browse/BEAM-925
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Daniel Halperin
> Assignee: Davor Bonaci
>
> {code}
> [INFO] Format-string method String.format(String, Object[]) called with format string "Cannot create output file at {}" wants 0 arguments but is given 1 in org.apache.beam.runners.dataflow.DataflowRunner.run(Pipeline) [org.apache.beam.runners.dataflow.DataflowRunner] At DataflowRunner.java:[line 578]
> [INFO] Format-string method String.format(String, Object[]) called with format string "Location must be local or on Cloud Storage, got {}." wants 0 arguments but is given 1 in org.apache.beam.runners.dataflow.DataflowRunner.run(Pipeline) [org.apache.beam.runners.dataflow.DataflowRunner] At DataflowRunner.java:[line 567]
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsIterable defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsIterable] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsList defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsList] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMap] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMultimap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsMultimap] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsSingleton defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchViewAsSingleton] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$BatchWrite defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$BatchWrite] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMap] In DataflowRunner.java
> [INFO] Class org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMultimap defines non-transient non-serializable instance field runner [org.apache.beam.runners.dataflow.DataflowRunner$StreamingViewAsMultimap] In DataflowRunner.java
> [INFO] Possible null pointer dereference of DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource.reader in org.apache.beam.runners.dataflow.internal.DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource.advance() [org.apache.beam.runners.dataflow.internal.DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource, org.apache.beam.runners.dataflow.internal.DataflowUnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource] Dereferenced at DataflowUnboundedReadFromBoundedSource.java:[line 495]Known null at DataflowUnboundedReadFromBoundedSource.java:[line 491]
> [INFO] Nullcheck of record at line 412 of value previously dereferenced in org.apache.beam.runners.dataflow.internal.IsmFormat$IsmRecordCoder.structuralValue(IsmFormat$IsmRecord) [org.apache.beam.runners.dataflow.internal.IsmFormat$IsmRecordCoder, org.apache.beam.runners.dataflow.internal.IsmFormat$IsmRecordCoder] At IsmFormat.java:[line 407]Redundant null check at IsmFormat.java:[line 412]
> [INFO] org.apache.beam.runners.dataflow.util.MonitoringUtil$TimeStampComparator implements Comparator but not Serializable [org.apache.beam.runners.dataflow.util.MonitoringUtil$TimeStampComparator] At MonitoringUtil.java:[lines 131-142]
> [INFO] Unread field: org.apache.beam.runners.dataflow.util.OutputReference.type; should this field be static? [org.apache.beam.runners.dataflow.util.OutputReference] At OutputReference.java:[line 30]
> [INFO] org.apache.beam.runners.dataflow.util.RandomAccessData$UnsignedLexicographicalComparator implements Comparator but not Serializable [org.apache.beam.runners.dataflow.util.RandomAccessData$UnsignedLexicographicalComparator] At RandomAccessData.java:[lines 129-183]
> [INFO] Boxing/unboxing to parse a primitive org.apache.beam.runners.dataflow.util.TimeUtil.fromCloudDuration(String) [org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil] At TimeUtil.java:[line 148]Another occurrence at TimeUtil.java:[line 151]
> [INFO] Boxing/unboxing to parse a primitive org.apache.beam.runners.dataflow.util.TimeUtil.fromCloudTime(String) [org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil, org.apache.beam.runners.dataflow.util.TimeUtil] At TimeUtil.java:[line 95]Another occurrence at TimeUtil.java:[line 96]Another occurrence at TimeUtil.java:[line 97]Another occurrence at TimeUtil.java:[line 98]Another occurrence at TimeUtil.java:[line 99]Another occurrence at TimeUtil.java:[line 100]Another occurrence at TimeUtil.java:[line 105]
> [INFO]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)