You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2021/06/30 14:42:31 UTC

Review Request 73438: RANGER-3325: Roles information not present in the Excel and CSV files which are downloaded from Reports page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73438/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.


Bugs: RANGER-3325
    https://issues.apache.org/jira/browse/RANGER-3325


Repository: ranger


Description
-------

**Problem Statement:**
When exporting the policies from the Reports page in Excel and CSV format,
the information about the roles in the policy is not present.
The roles information for a particular policy is visible when the policy information
is exported in JSON format.

**Steps to reproduce:**

1. Create a role
2. Create a policy on that role
3. On the reports page, export the policies information in all the three available formats ( Excel, CSV, JSON).
4. When the files are inspected, the roles information in the policy is present only in the JSON file. Not in the Excel and CSV files.

**Proposed Solution:**
Patch will add the role information also while generating the Excel/CSV files. Policy's roles details are already available in the filtered policies list.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 50ab32f9b 


Diff: https://reviews.apache.org/r/73438/diff/1/


Testing
-------

Tested with patch and able to see policy roles for each policy in the downloaded Excel and CSV file.


Thanks,

Pradeep Agrawal


Re: Review Request 73438: RANGER-3325: Roles information not present in the Excel and CSV files which are downloaded from Reports page

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73438/#review223225
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On June 30, 2021, 2:42 p.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73438/
> -----------------------------------------------------------
> 
> (Updated June 30, 2021, 2:42 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3325
>     https://issues.apache.org/jira/browse/RANGER-3325
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement:**
> When exporting the policies from the Reports page in Excel and CSV format,
> the information about the roles in the policy is not present.
> The roles information for a particular policy is visible when the policy information
> is exported in JSON format.
> 
> **Steps to reproduce:**
> 
> 1. Create a role
> 2. Create a policy on that role
> 3. On the reports page, export the policies information in all the three available formats ( Excel, CSV, JSON).
> 4. When the files are inspected, the roles information in the policy is present only in the JSON file. Not in the Excel and CSV files.
> 
> **Proposed Solution:**
> Patch will add the role information also while generating the Excel/CSV files. Policy's roles details are already available in the filtered policies list.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 50ab32f9b 
> 
> 
> Diff: https://reviews.apache.org/r/73438/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with patch and able to see policy roles for each policy in the downloaded Excel and CSV file.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>