You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/05/09 19:36:37 UTC
[GitHub] [helix] qqu0127 opened a new pull request, #2086: Refactor bump-up.command script and add helix-view-cluster
qqu0127 opened a new pull request, #2086:
URL: https://github.com/apache/helix/pull/2086
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fix https://github.com/apache/helix/issues/2085
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Code cleanup and refactoring in bump-up.command, also added helix-view-cluster to it. There shouldn't be any functional change.
### Tests
- [ ] The following tests are written for this issue:
Manually tested the script with internal lib.
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2086:
URL: https://github.com/apache/helix/pull/2086#discussion_r868468809
##########
bump-up.command:
##########
@@ -19,6 +19,30 @@
# under the License.
#
+MODULES=("metrics-common" "metadata-store-directory-common" "zookeeper-api" "helix-common" "helix-core" \
+"helix-admin-webapp" "helix-front" "helix-rest" "helix-lock" "helix-view-aggregator" "helix-agent")
+
+update_pom_version() {
+ pom=$1
+ echo "bump up $pom"
+ sed -i "s/${version}/${new_version}/g" $pom
Review Comment:
Hey @narendly , thanks for the comment.
Not sure if I understand it correctly, but it seems `sed` doesn't complain if the pattern is not found. We actually need to do extra work to make it error out in such case https://unix.stackexchange.com/questions/55810/is-there-an-option-to-make-sed-fail-if-pattern-not-found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a diff in pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
junkaixue commented on code in PR #2086:
URL: https://github.com/apache/helix/pull/2086#discussion_r868785640
##########
bump-up.command:
##########
@@ -19,6 +19,30 @@
# under the License.
#
+MODULES=("metrics-common" "metadata-store-directory-common" "zookeeper-api" "helix-common" "helix-core" \
+"helix-admin-webapp" "helix-front" "helix-rest" "helix-lock" "helix-view-aggregator" "helix-agent")
+
+update_pom_version() {
+ pom=$1
+ echo "bump up $pom"
+ sed -i "s/${version}/${new_version}/g" $pom
Review Comment:
For Mac, sed may not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
junkaixue commented on PR #2086:
URL: https://github.com/apache/helix/pull/2086#issuecomment-1122705777
@qqu0127 ready for merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on PR #2086:
URL: https://github.com/apache/helix/pull/2086#issuecomment-1122709055
@junkaixue Yes, it's ready to merge, thank you all for the review and approval.
Commit message:
Refactor bump-up.command script and add helix-view-aggregator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2086:
URL: https://github.com/apache/helix/pull/2086#discussion_r868522423
##########
bump-up.command:
##########
@@ -19,6 +19,30 @@
# under the License.
#
+MODULES=("metrics-common" "metadata-store-directory-common" "zookeeper-api" "helix-common" "helix-core" \
+"helix-admin-webapp" "helix-front" "helix-rest" "helix-lock" "helix-view-aggregator" "helix-agent")
+
+update_pom_version() {
+ pom=$1
+ echo "bump up $pom"
+ sed -i "s/${version}/${new_version}/g" $pom
Review Comment:
Added a check with `grep` instead since it's already there and is a smaller change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a diff in pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
narendly commented on code in PR #2086:
URL: https://github.com/apache/helix/pull/2086#discussion_r868433330
##########
bump-up.command:
##########
@@ -19,6 +19,30 @@
# under the License.
#
+MODULES=("metrics-common" "metadata-store-directory-common" "zookeeper-api" "helix-common" "helix-core" \
+"helix-admin-webapp" "helix-front" "helix-rest" "helix-lock" "helix-view-aggregator" "helix-agent")
+
+update_pom_version() {
+ pom=$1
+ echo "bump up $pom"
+ sed -i "s/${version}/${new_version}/g" $pom
Review Comment:
Thanks for refactoring! Another nagging issue we've had with this script is that if `sed` isn't able to locate the correct `version`, it just fails out, and those who aren't familiar with the way bump-up.command would get stuck.
I think it might be helpful to add some error log based on the exit code - any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2086:
URL: https://github.com/apache/helix/pull/2086#discussion_r869502256
##########
bump-up.command:
##########
@@ -19,6 +19,30 @@
# under the License.
#
+MODULES=("metrics-common" "metadata-store-directory-common" "zookeeper-api" "helix-common" "helix-core" \
+"helix-admin-webapp" "helix-front" "helix-rest" "helix-lock" "helix-view-aggregator" "helix-agent")
+
+update_pom_version() {
+ pom=$1
+ echo "bump up $pom"
+ sed -i "s/${version}/${new_version}/g" $pom
Review Comment:
Thanks @junkaixue I believe this is existing behavior though.
I updated the command to make it work on both Mac and linux, referring to https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2086: Refactor bump-up.command script and add helix-view-aggregator
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2086:
URL: https://github.com/apache/helix/pull/2086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org