[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #109: [FLINK-27528] Introduce a new configuration option 'compact.rescale-bucket' for FileStore

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #109:
URL: https://github.com/apache/flink-table-store/pull/109#discussion_r866665195


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java:
##########
@@ -92,6 +92,17 @@ public class FileStoreOptions implements Serializable {
                             "The default partition name in case the dynamic partition"
                                     + " column value is null/empty string.");
 
+    public static final ConfigOption<Boolean> COMPACTION_RESCALE_BUCKET =
+            key("compact.rescale-bucket")

Review Comment:
   ah.. my point is `compaction` instead of `compact`.
   About where, maybe it is better to move this key to `TableStoreFactoryOptions`? Because actually only TableStoreFactory will read it.
   (In future, maybe we should merge all `XXOptions` to one class.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org