You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2017/09/21 15:11:43 UTC

[GitHub] storm pull request #2337: [STORM2751] Removing AsyncLoggerContext from Super...

GitHub user kishorvpatil opened a pull request:

    https://github.com/apache/storm/pull/2337

    [STORM2751] Removing AsyncLoggerContext from Supervisor Configuration

    If disk can not keep it up with all logging, the {{AsyncLoggingContext}} causes large heap memory be utilized causing the JVM to churn CPU.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kishorvpatil/incubator-storm storm2751

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2337
    
----
commit b7ed06f82650dd762ec2f422b024268c561076a2
Author: Kishor Patil <kp...@yahoo-inc.com>
Date:   2017-09-21T15:09:05Z

    Removing AsyncLoggerContext from Supervisor Configuration

----


---

[GitHub] storm issue #2337: [STORM2751] Removing AsyncLoggerContext from Supervisor C...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2337
  
    @kishorvpatil 
    Are you observing the issue only from Supervisor?
    I understand what the patch would want to address, but just to be sure about that patch because we have another daemons as well.
    If it only occurs from Supervisor, we may want to revisit Supervisor to check whether it is too verbose.


---

[GitHub] storm issue #2337: [STORM2751] Removing AsyncLoggerContext from Supervisor C...

Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the issue:

    https://github.com/apache/storm/pull/2337
  
    @HeartSaVioR 
    I am noticed it on supervisors, but I am suspecting topologies being too verbose making many workers adding load on disk. I am not sure if supervisor is too verbose. But with limited memory ( 256MB) assigned to it, I noticed it only only on supervisor. 


---

[GitHub] storm issue #2337: [STORM2751] Removing AsyncLoggerContext from Supervisor C...

Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the issue:

    https://github.com/apache/storm/pull/2337
  
    @HeartSaVioR I do not notice this on logviewer but clearly it do not have so much activity or logging for that matter.


---

[GitHub] storm pull request #2337: [STORM2751] Removing AsyncLoggerContext from Super...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2337


---

[GitHub] storm pull request #2337: [STORM2751] Removing AsyncLoggerContext from Super...

Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2337#discussion_r140328729
  
    --- Diff: bin/storm.py ---
    @@ -739,7 +739,6 @@ def supervisor(klass="org.apache.storm.daemon.supervisor.Supervisor"):
         cppaths = [CLUSTER_CONF_DIR]
         jvmopts = parse_args(confvalue("supervisor.childopts", cppaths)) + [
             "-Dlogfile.name=" + STORM_SUPERVISOR_LOG_FILE,
    -        "-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector",
    --- End diff --
    
    synchronized logging might slow down UI response time. May be if we notice this in future we can remove it.


---

[GitHub] storm pull request #2337: [STORM2751] Removing AsyncLoggerContext from Super...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2337#discussion_r140313025
  
    --- Diff: bin/storm.py ---
    @@ -739,7 +739,6 @@ def supervisor(klass="org.apache.storm.daemon.supervisor.Supervisor"):
         cppaths = [CLUSTER_CONF_DIR]
         jvmopts = parse_args(confvalue("supervisor.childopts", cppaths)) + [
             "-Dlogfile.name=" + STORM_SUPERVISOR_LOG_FILE,
    -        "-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector",
    --- End diff --
    
    Do we want to remove this for the UI and other daemons too?


---

[GitHub] storm issue #2337: [STORM2751] Removing AsyncLoggerContext from Supervisor C...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2337
  
    +1 from me too.


---