You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alex Boisvert (Created) (JIRA)" <ji...@apache.org> on 2011/11/15 12:16:52 UTC
[jira] [Created] (BUILDR-615) Support non-numeric characters in
VersionRequirement (e.g. version = "r09")
Support non-numeric characters in VersionRequirement (e.g. version = "r09")
---------------------------------------------------------------------------
Key: BUILDR-615
URL: https://issues.apache.org/jira/browse/BUILDR-615
Project: Buildr
Issue Type: Bug
Components: Dependency management
Affects Versions: 1.4.6
Reporter: Alex Boisvert
Assignee: Alex Boisvert
Priority: Minor
>From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
Consider the following namespace code:
REQUIRES = ArtifactNamespace.for(self) do |ns|
ns.guava! "com.google.guava:guava:jar:r09"
ns.javassist! "javassist:javassist:jar:3.8.0.GA"
ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
end
The guava spec here causes the following error to be raised
Invalid version: "r09"
This is a result of VersionRequirement.version? which checks the version
string against the regex
/^\s*\d[#{VER_CHARS}]*\s*$/
This regex is checked here
raise "Invalid version: #{version.inspect}" unless
self.class.version?(version)
So it seems that maybe this regex could be expanded to include versions
like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BUILDR-615) Support non-numeric characters in
VersionRequirement (e.g. version = "r09")
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158250#comment-13158250 ]
Hudson commented on BUILDR-615:
-------------------------------
Integrated in Buildr-ci-build #296 (See [https://builds.apache.org/job/Buildr-ci-build/296/])
BUILDR-615 VersionRequirement.version? now returns true for versions following pattern "r9999", e.g. "r09"
boisvert :
Files :
* /buildr/trunk/CHANGELOG
* /buildr/trunk/lib/buildr/packaging/version_requirement.rb
* /buildr/trunk/spec/version_requirement_spec.rb
> Support non-numeric characters in VersionRequirement (e.g. version = "r09")
> ---------------------------------------------------------------------------
>
> Key: BUILDR-615
> URL: https://issues.apache.org/jira/browse/BUILDR-615
> Project: Buildr
> Issue Type: Bug
> Components: Dependency management
> Affects Versions: 1.4.6
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Priority: Minor
> Fix For: 1.4.8
>
>
> From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
> Consider the following namespace code:
> REQUIRES = ArtifactNamespace.for(self) do |ns|
> ns.guava! "com.google.guava:guava:jar:r09"
> ns.javassist! "javassist:javassist:jar:3.8.0.GA"
> ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
> end
> The guava spec here causes the following error to be raised
> Invalid version: "r09"
> This is a result of VersionRequirement.version? which checks the version
> string against the regex
> /^\s*\d[#{VER_CHARS}]*\s*$/
> This regex is checked here
> raise "Invalid version: #{version.inspect}" unless
> self.class.version?(version)
> So it seems that maybe this regex could be expanded to include versions
> like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BUILDR-615) Support non-numeric characters in
VersionRequirement (e.g. version = "r09")
Posted by "Alex Boisvert (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-615:
---------------------------------
Fix Version/s: 1.4.8
> Support non-numeric characters in VersionRequirement (e.g. version = "r09")
> ---------------------------------------------------------------------------
>
> Key: BUILDR-615
> URL: https://issues.apache.org/jira/browse/BUILDR-615
> Project: Buildr
> Issue Type: Bug
> Components: Dependency management
> Affects Versions: 1.4.6
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Priority: Minor
> Fix For: 1.4.8
>
>
> From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
> Consider the following namespace code:
> REQUIRES = ArtifactNamespace.for(self) do |ns|
> ns.guava! "com.google.guava:guava:jar:r09"
> ns.javassist! "javassist:javassist:jar:3.8.0.GA"
> ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
> end
> The guava spec here causes the following error to be raised
> Invalid version: "r09"
> This is a result of VersionRequirement.version? which checks the version
> string against the regex
> /^\s*\d[#{VER_CHARS}]*\s*$/
> This regex is checked here
> raise "Invalid version: #{version.inspect}" unless
> self.class.version?(version)
> So it seems that maybe this regex could be expanded to include versions
> like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (BUILDR-615) Support non-numeric characters in
VersionRequirement (e.g. version = "r09")
Posted by "Peter Donald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Donald closed BUILDR-615.
-------------------------------
> Support non-numeric characters in VersionRequirement (e.g. version = "r09")
> ---------------------------------------------------------------------------
>
> Key: BUILDR-615
> URL: https://issues.apache.org/jira/browse/BUILDR-615
> Project: Buildr
> Issue Type: Bug
> Components: Dependency management
> Affects Versions: 1.4.6
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Priority: Minor
> Fix For: 1.4.8
>
>
> From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
> Consider the following namespace code:
> REQUIRES = ArtifactNamespace.for(self) do |ns|
> ns.guava! "com.google.guava:guava:jar:r09"
> ns.javassist! "javassist:javassist:jar:3.8.0.GA"
> ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
> end
> The guava spec here causes the following error to be raised
> Invalid version: "r09"
> This is a result of VersionRequirement.version? which checks the version
> string against the regex
> /^\s*\d[#{VER_CHARS}]*\s*$/
> This regex is checked here
> raise "Invalid version: #{version.inspect}" unless
> self.class.version?(version)
> So it seems that maybe this regex could be expanded to include versions
> like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BUILDR-615) Support non-numeric characters in
VersionRequirement (e.g. version = "r09")
Posted by "Alex Boisvert (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158214#comment-13158214 ]
Alex Boisvert commented on BUILDR-615:
--------------------------------------
Just to clarify, we're now allowing version strings beginning with "r", e.g. "r09"
> Support non-numeric characters in VersionRequirement (e.g. version = "r09")
> ---------------------------------------------------------------------------
>
> Key: BUILDR-615
> URL: https://issues.apache.org/jira/browse/BUILDR-615
> Project: Buildr
> Issue Type: Bug
> Components: Dependency management
> Affects Versions: 1.4.6
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Priority: Minor
> Fix For: 1.4.8
>
>
> From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
> Consider the following namespace code:
> REQUIRES = ArtifactNamespace.for(self) do |ns|
> ns.guava! "com.google.guava:guava:jar:r09"
> ns.javassist! "javassist:javassist:jar:3.8.0.GA"
> ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
> end
> The guava spec here causes the following error to be raised
> Invalid version: "r09"
> This is a result of VersionRequirement.version? which checks the version
> string against the regex
> /^\s*\d[#{VER_CHARS}]*\s*$/
> This regex is checked here
> raise "Invalid version: #{version.inspect}" unless
> self.class.version?(version)
> So it seems that maybe this regex could be expanded to include versions
> like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (BUILDR-615) Support non-numeric characters in
VersionRequirement (e.g. version = "r09")
Posted by "Alex Boisvert (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-615.
----------------------------------
Resolution: Fixed
Fixed.
boisvert@honeybrown:~/git/buildr$ git svn dcommit
Committing to https://svn.apache.org/repos/asf/buildr/trunk ...
M CHANGELOG
M spec/version_requirement_spec.rb
M lib/buildr/packaging/version_requirement.rb
r1206985 = 5b57fb67d958bfcdcf1348e0a7ef0a45e45c066e (refs/remotes/origin/trunk)
> Support non-numeric characters in VersionRequirement (e.g. version = "r09")
> ---------------------------------------------------------------------------
>
> Key: BUILDR-615
> URL: https://issues.apache.org/jira/browse/BUILDR-615
> Project: Buildr
> Issue Type: Bug
> Components: Dependency management
> Affects Versions: 1.4.6
> Reporter: Alex Boisvert
> Assignee: Alex Boisvert
> Priority: Minor
>
> From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
> Consider the following namespace code:
> REQUIRES = ArtifactNamespace.for(self) do |ns|
> ns.guava! "com.google.guava:guava:jar:r09"
> ns.javassist! "javassist:javassist:jar:3.8.0.GA"
> ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
> end
> The guava spec here causes the following error to be raised
> Invalid version: "r09"
> This is a result of VersionRequirement.version? which checks the version
> string against the regex
> /^\s*\d[#{VER_CHARS}]*\s*$/
> This regex is checked here
> raise "Invalid version: #{version.inspect}" unless
> self.class.version?(version)
> So it seems that maybe this regex could be expanded to include versions
> like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira