You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Prasad Chakka (JIRA)" <ji...@apache.org> on 2009/05/26 08:14:45 UTC
[jira] Created: (HIVE-516) Enable predicate pushdown for junit
tests
Enable predicate pushdown for junit tests
-----------------------------------------
Key: HIVE-516
URL: https://issues.apache.org/jira/browse/HIVE-516
Project: Hadoop Hive
Issue Type: Task
Components: Testing Infrastructure
Affects Versions: 0.4.0
Reporter: Prasad Chakka
Assignee: Prasad Chakka
Fix For: 0.4.0
Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716436#action_12716436 ]
Namit Jain commented on HIVE-516:
---------------------------------
the patch has been generated from ql directory. Can you regenerate the patch ?
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-516:
-------------------------------
Attachment: hive-516.2.patch
this one is from base dir. sorry about that.
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-516:
-------------------------------
Attachment: hive-516.patch
two tests that are interesting
ql/src/test/results/clientpositive/order2.q.out
predicate changes type from string to int, so the 'key < 10' filter behaves differently.
ql/src/test/results/clientpositive/rand_partitionpruner3.q.out
rand() is applied after filtering rows so number of output rows are smaller than before.
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716434#action_12716434 ]
Namit Jain commented on HIVE-516:
---------------------------------
I did not go over all the test plan outputs - I made sure that there are no data changes.
+1
looks good. will commit if the tests pass
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716445#action_12716445 ]
Namit Jain commented on HIVE-516:
---------------------------------
After discussing more with Raghu, it will not be a good idea to enable predicate pushdown in junit, and disable them otherwise.
Any production system is using a codebase, which we are not testing.
So, it would be necessary to run tests in junit with predicate pushdown enabled and disabled.
However, it would increase the time of unit tests substantially. We need the unit tests in parallel before that
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-516:
-------------------------------
Status: Patch Available (was: Open)
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-516:
-------------------------------
Description: Enable predicate pushdown by default. (was: Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.)
Summary: Enable predicate pushdown (was: Enable predicate pushdown for junit tests)
> Enable predicate pushdown
> -------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.3.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-516:
-------------------------------
Attachment: hive-516.3.patch
here is the latest patch for enabling partition pruning in hive-default.xml
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.3.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723373#action_12723373 ]
Zheng Shao commented on HIVE-516:
---------------------------------
Testing: Will commit when test succeeds.
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.3.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-516:
----------------------------
Resolution: Fixed
Release Note: HIVE-516. Enable predicate pushdown for junit tests. (Prasad Chakka via zshao)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Prasad.
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.3.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-516) Enable predicate pushdown for junit
tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-516:
-------------------------------
Attachment: hive-516.patch
> Enable predicate pushdown for junit tests
> -----------------------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown for junit tests by default. this is first step in making predicate pushdown as default option in the next release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-516) Enable predicate pushdown
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723432#action_12723432 ]
Prasad Chakka commented on HIVE-516:
------------------------------------
changed title and description. this feature has been in for quite sometime and enabling it before we make a branch for 0.4
> Enable predicate pushdown
> -------------------------
>
> Key: HIVE-516
> URL: https://issues.apache.org/jira/browse/HIVE-516
> Project: Hadoop Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Fix For: 0.4.0
>
> Attachments: hive-516.2.patch, hive-516.3.patch, hive-516.patch, hive-516.patch
>
>
> Enable predicate pushdown by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.