[GitHub] [ozone] rakeshadr commented on a diff in pull request #3554: HDDS-6951. Replace bucket.listKeys() with bucket.listStatus() in OmBucketReadWriteKeyOps

[GitBox <gi...@apache.org>]

rakeshadr commented on code in PR #3554:
URL: https://github.com/apache/ozone/pull/3554#discussion_r936385625


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OmBucketReadWriteKeyOps.java:
##########
@@ -128,12 +128,10 @@ protected String createPath(String path) {
   @Override
   protected int getReadCount(int readCount, String readPath)
       throws IOException {
-    Iterator<? extends OzoneKey> ozoneKeyIterator = bucket.listKeys(
-        OzoneConsts.OM_KEY_PREFIX + readPath + OzoneConsts.OM_KEY_PREFIX);
-    while (ozoneKeyIterator.hasNext()) {
-      ozoneKeyIterator.next();
-      ++readCount;
-    }
+    List<OzoneFileStatus> ozoneFileStatusList = bucket.listStatus(
+        OzoneConsts.OM_KEY_PREFIX + readPath + OzoneConsts.OM_KEY_PREFIX, true,
+        "/", keyCountForRead);

Review Comment:
   > @ayushtkn what you point out makes sense. The reason it is not relevant here is that freon is a CLI extension used to generate load for testing. The user might not want to have a limit as they might be profiling memory or CPU. The CLI invocation has a [default value that can be overridden ](https://github.com/apache/ozone/pull/3554/files#diff-1fa33049586e9221ab06c5c11fba5033a8ca68a28b8fe5ccefe4b676ef4f9c0fR62-R65)
   
   Thanks a lot @ayushtkn for the reviews. 
   
   Agreed with @kerneltime. Since its a stress/benchmarking tool, I am more inclined to keep this value open to the users and they can tune this based on their cluster resource capabilities.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org