You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/22 10:37:10 UTC

[GitHub] [beam] mosche commented on a diff in pull request #17172: [BEAM-14166] Performance improvements for RowWithGetter

mosche commented on code in PR #17172:
URL: https://github.com/apache/beam/pull/17172#discussion_r903575769


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueGetter.java:
##########
@@ -33,5 +33,9 @@
   @Nullable
   ValueT get(ObjectT object);
 
+  default @Nullable Object getRaw(ObjectT object) {

Review Comment:
   @TheNeuralBit I've opened a new PR to add the missing comment, sorry for the delay.
   https://github.com/apache/beam/pull/21982



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org