You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@wandisco.com> on 2010/03/26 11:57:16 UTC

Re: svn commit: r927552 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

gstein@apache.org writes:

> Author: gstein
> Date: Thu Mar 25 19:24:42 2010
> New Revision: 927552
>
> URL: http://svn.apache.org/viewvc?rev=927552&view=rev
> Log:
> Break out the guts of svn_wc__db_wq_add() into an internal helper function
> for future support where work items are passed into db_op_*().
>
> * subversion/libsvn_wc/wc_db.c:
>   (add_single_work_item): new helper function to insert a single row into
>     the WORK_QUEUE table.
>   (add_work_items): new function to insert 0 or more work items into a
>     given SDB.
>   (svn_wc__db_wq_add): gut this and just call add_work_items()
>
> Modified:
>     subversion/trunk/subversion/libsvn_wc/wc_db.c

This causes db-test to fail. svn_wc__db_wq_add used to accept atoms
and now requires a list.

-- 
Philip

Re: svn commit: r927552 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

Posted by Julian Foad <ju...@wandisco.com>.
Philip Martin wrote:
> gstein@apache.org writes:
> 
> > Author: gstein
> > Date: Thu Mar 25 19:24:42 2010
> > New Revision: 927552
> >
> > URL: http://svn.apache.org/viewvc?rev=927552&view=rev
> > Log:
> > Break out the guts of svn_wc__db_wq_add() into an internal helper function
> > for future support where work items are passed into db_op_*().
> >
> > * subversion/libsvn_wc/wc_db.c:
> >   (add_single_work_item): new helper function to insert a single row into
> >     the WORK_QUEUE table.
> >   (add_work_items): new function to insert 0 or more work items into a
> >     given SDB.
> >   (svn_wc__db_wq_add): gut this and just call add_work_items()
> >
> > Modified:
> >     subversion/trunk/subversion/libsvn_wc/wc_db.c
> 
> This causes db-test to fail. svn_wc__db_wq_add used to accept atoms
> and now requires a list.

Bert fixed it in r927792.

- Julian