[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4523: [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

[GitBox <gi...@apache.org>]

jongyoul commented on code in PR #4523:
URL: https://github.com/apache/zeppelin/pull/4523#discussion_r1044415208


##########
zeppelin-jupyter-interpreter-shaded/pom.xml:
##########
@@ -36,6 +36,28 @@
       <groupId>${project.groupId}</groupId>
       <artifactId>zeppelin-jupyter-interpreter</artifactId>
       <version>${project.version}</version>
+      <exclusions>
+        <exclusion>
+          <groupId>com.google.protobuf</groupId>
+          <artifactId>protobuf-java</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>com.google.errorprone</groupId>
+          <artifactId>error_prone_annotations</artifactId>
+        </exclusion>
+      </exclusions>
+    </dependency>
+
+    <dependency>
+      <groupId>com.google.protobuf</groupId>
+      <artifactId>protobuf-java</artifactId>
+      <version>${protobuf.version}</version>
+    </dependency>
+
+    <dependency>
+      <groupId>com.google.errorprone</groupId>
+      <artifactId>error_prone_annotations</artifactId>
+      <version>2.14.0</version>

Review Comment:
   Could you please follow our current format to define the version of this dependency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org